Scatter adjustments [VS-516] #8835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mcovarr
commented
May 15, 2024
•
mcovarr
commented
- Successful Quickstart extract into 23 per-chromosome VCFs.
- Successful exome extract with the new scatter width of 2500.
mcovarr
force-pushed
the
vs_1374_fix_integration_tests
branch
from
95283fd
to
082cfff
Compare
mcovarr
force-pushed
the
vs_516_not_so_wide
branch
2 times, most recently
from
9e2c32e
to
715e386
Compare
mcovarr
changed the base branch from
vs_1374_fix_integration_tests
to
ah_var_store
mcovarr
force-pushed
the
vs_516_not_so_wide
branch
from
715e386
to
5f3a143
Compare
mcovarr
force-pushed
the
vs_516_not_so_wide
branch
from
5f3a143
to
0a7407a
Compare
gbggrant
approved these changes
May 16, 2024
RoriCremer
approved these changes
May 16, 2024
RoriCremer
reviewed
May 16, 2024
| else if is_wgs then 20000 else 7500 | ||
| else if is_wgs then | ||
| if GetNumSamplesLoaded.num_samples < 5000 then 1 # This results in 1 VCF per chromosome. | ||
| else if GetNumSamplesLoaded.num_samples < 20000 then 2000 # Stroke Anderson |
There was a problem hiding this comment.
is there any reason to reference Stroke Anderson if we dont even have access to that data anymore?
There was a problem hiding this comment.
trying to manifest finding a copy of it somewhere? 🤷
gbggrant
pushed a commit
that referenced
this pull request
May 25, 2024
gbggrant
added a commit
that referenced
this pull request
May 28, 2024
* VS-1397 Update Tests - ah_var_store edition (#8846) ** Add ValidateVariants to our tests. ** Bringing in Rori's change to add EXCESS_ALLELES to VCF Headers. ** Updated truth path. * Scatter adjustments [VS-516] (#8835) Co-authored-by: Miguel Covarrubias <[email protected]>
RoriCremer
pushed a commit
that referenced
this pull request
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.