Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VS-1397 Update Tests - ah_var_store edition #8846

Merged
merged 14 commits into from
May 24, 2024
Merged

VS-1397 Update Tests - ah_var_store edition #8846

merged 14 commits into from
May 24, 2024

Conversation

gbggrant
Copy link
Collaborator

@gbggrant gbggrant commented May 23, 2024 •
edited
Loading

Updates:

  • Changes to scatter width of VCFs generated has changed the amount of data generated in tests, so need to update truth
  • Adding a new field to extracted VCF Header EXCESS_ALLLELES and that will break the tests.
  • And why not validate our VCFs for jollies.
  • Updates 'truth' path for data to match these changes.

Integration Tests:
Passing test against Chr20/X/Y Here
Passing test against All Chromosomes Here

@gatk-bot
Copy link

gatk-bot commented May 23, 2024 •
edited
Loading

Github actions tests reported job failures from actions build 9214455463
Failures in the following jobs:

Test Type JDK Job ID Logs
unit 17.0.6+10 9214455463.12 logs
unit 17.0.6+10 9214455463.1 logs

@gatk-bot
Copy link

gatk-bot commented May 23, 2024 •
edited
Loading

Github actions tests reported job failures from actions build 9214610801
Failures in the following jobs:

Test Type JDK Job ID Logs
unit 17.0.6+10 9214610801.12 logs
unit 17.0.6+10 9214610801.1 logs

@gbggrant gbggrant marked this pull request as ready for review May 24, 2024 14:47
mcovarr
mcovarr approved these changes May 24, 2024
View reviewed changes
Copy link
Collaborator

@mcovarr mcovarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the fix!

@gbggrant gbggrant merged commit b081919 into ah_var_store May 24, 2024
11 of 17 checks passed
@gbggrant gbggrant deleted the gg_VS-1397_UpdateTests branch May 24, 2024 18:15
gbggrant added a commit that referenced this pull request May 24, 2024
@gbggrant
VS-1397 Update Tests - ah_var_store edition (#8846)
9b36425 
* Add ValidateVariants to our tests.
* Bringing in Rori's change to add EXCESS_ALLELES to VCF Headers.
* Updated truth path.
gbggrant added a commit that referenced this pull request May 28, 2024
@gbggrant @mcovarr
VS-1397 update tests echo callset version (#8848)
634bce9 
* VS-1397 Update Tests - ah_var_store edition (#8846)
** Add ValidateVariants to our tests.
** Bringing in Rori's change to add EXCESS_ALLELES to VCF Headers.
** Updated truth path.
* Scatter adjustments [VS-516] (#8835)

Co-authored-by: Miguel Covarrubias <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoriCremer RoriCremer RoriCremer approved these changes

@mcovarr mcovarr mcovarr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gbggrant @gatk-bot @RoriCremer @mcovarr