Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to htsjdk 3.0.0. #1812

Merged
merged 2 commits into from
Jun 8, 2022
Merged

Upgrade to htsjdk 3.0.0. #1812

merged 2 commits into from
Jun 8, 2022

Conversation

cmnbroad
Copy link
Contributor

@cmnbroad cmnbroad commented Jun 1, 2022

The latest release of htsjdk changes the Allele class into an interface, and replaces it with a concrete implementation class SimpleAllele that has a different hashCode and Comparable implementation than before. One existing GenotypeConcordance test fails with the new implementation, fixed in this PR.

@cmnbroad cmnbroad marked this pull request as draft June 1, 2022 13:18
@cmnbroad cmnbroad marked this pull request as ready for review June 1, 2022 13:58
@gbggrant gbggrant requested a review from yfarjoun June 2, 2022 19:38
@gbggrant
Copy link
Contributor

gbggrant commented Jun 2, 2022

retest this please

@cmnbroad cmnbroad changed the title Fix code GenotypeConcordance code that is sensitive to Allele ordering. Upgrade to htsjdk 3.0.0. Jun 7, 2022
@lbergelson
Copy link
Member

@gbggrant We'd love to get this merged soon if someone could take a look at it.

@gbggrant gbggrant merged commit 09183c8 into master Jun 8, 2022
@cmnbroad
Copy link
Contributor Author

@gbggrant @kbergin I'm not sure who is responsible for picard-private these days, but the htsjdk update in this commit will likely result in the need for some (probably minor) source updates in picard-private. Is there someone else I should ping to give a heads up ?

@cmnbroad cmnbroad deleted the cn_htsjdk_alleles branch June 13, 2022 19:28
@kbergin
Copy link
Contributor

kbergin commented Jun 21, 2022

Thank you for letting us know @cmnbroad. I've made a ticket for pipelines team to address this in picard-private.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants