Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added traditional chinese translation (zh-TW) #40

Merged
merged 3 commits into from
Oct 28, 2019
Merged

Added traditional chinese translation (zh-TW) #40

merged 3 commits into from
Oct 28, 2019

Conversation

janeliutw
Copy link
Contributor

@janeliutw janeliutw commented Oct 28, 2019

issue #2
This is translation to Traditional Chinese (Taiwan)

@btk btk merged commit 1eca052 into btk:master Oct 28, 2019
@btk
Copy link
Owner

btk commented Oct 28, 2019

Hey @janeliutw thank you so much!

Could you tell me how much difference is there between zh-CN and zh-TW is it noticeable or like en-US vs en-GB?

@janeliutw
Copy link
Contributor Author

@btk yeah, the file zn-CN is using Simplify Chinese, and zh-TW is using Traditional Chinese. So a lot of the characters are different, also the use of names/terms could be different as well!

@btk
Copy link
Owner

btk commented Oct 28, 2019

Ok thank you, also could you tell me about zh-Hans_HK vs zh-Hans_TW

I'm also going to add your name in app as contributors!

@janeliutw
Copy link
Contributor Author

Sure. Hongkong, Macau and Taiwan are the only places that are primarily using Traditional Chinese in the world, we share the same characters but might use different names/ terms in some cases. So it's more like en-US vs en-GB e.g., Taxi in HongKong and Macau would be called "的士", but in Taiwan we call "計程車".
If you would like to just have a general classification for Chinese, it would be Chinese (Traditional) and Chinese (Simplified), google translate is using this classification. But since this is a Language learning app, people might be using it when they travel to different countries, I would suggest to include different translations for Simplified (zh-CN), Traditional (zh-HK), and Traditional (zh-TW) as the usage of words are different.

More info if you are interested: https://en.wikipedia.org/wiki/Language_localisation
But I am also happy to answer any other questions you have!

Also, I am sorry but I just found out there was some typo in my PR, I was working late last night my eyes just got tired. I'll update it and create another PR if you don't mind.

@btk
Copy link
Owner

btk commented Oct 28, 2019

Thank you for the info, since this app targets kids with autism, using the exact terms are crucial, I will do as you suggest.

Also, I am sorry but I just found out there was some typo in my PR, I was working late last night my eyes just got tired. I'll update it and create another PR if you don't mind.

Sure you can always come back and do changes and add a new PR as I try to update the app every month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants