Merge pull request #3362 from TakeMeNL/bugfix/3269

Resolve #3269
cachethq · Dec 18, 2018 · 84fd584 · 84fd584
2 parents cddeac0 + 201322b
commit 84fd584
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/app/Bus/Commands/Component/CreateComponentCommand.php b/app/Bus/Commands/Component/CreateComponentCommand.php
@@ -81,7 +81,7 @@ final class CreateComponentCommand
      */
     public $rules = [
         'name'        => 'required|string',
-        'description' => 'required|string',
+        'description' => 'nullable|string',
         'status'      => 'required|int|min:0|max:4',
         'link'        => 'nullable|url',
         'order'       => 'nullable|int',

diff --git a/tests/Api/ComponentTest.php b/tests/Api/ComponentTest.php
@@ -84,6 +84,21 @@ public function test_can_create_component()
         $response->assertJsonFragment(['name' => 'Foo']);
     }
 
+    public function test_can_create_minimal_component()
+    {
+        $this->beUser();
+
+        $this->expectsEvents(ComponentWasCreatedEvent::class);
+
+        $response = $this->json('POST', '/api/v1/components', [
+            'name'        => 'Foo',
+            'status'      => 1,
+        ]);
+
+        $response->assertStatus(200);
+        $response->assertJsonFragment(['name' => 'Foo']);
+    }
+
     public function test_can_create_component_without_enabled_field()
     {
         $this->beUser();