Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create incident_components table #2642

Merged
merged 3 commits into from
Jul 25, 2017
Merged

Create incident_components table #2642

merged 3 commits into from
Jul 25, 2017

Conversation

jbrooksuk
Copy link
Member

This creates the incident_components table and model. It's not used yet but we'll start to soon.

@jbrooksuk jbrooksuk requested a review from joecohens July 18, 2017 21:53
@jbrooksuk jbrooksuk added this to the V2.4.0 milestone Jul 18, 2017
@jbrooksuk
Copy link
Member Author

@joecohens I'm tempted to add status_id for when #2643 is done. Would we want to store that data in here rather than on the component itself though?

@joecohens
Copy link
Contributor

If we want to "Cache" or potentially have history on the component statuses, it would be cool to have it ;)

@jbrooksuk
Copy link
Member Author

A history of statuses would be useful! Yep, will add it before I merge this.

@GrahamCampbell
Copy link
Contributor

👍

@jbrooksuk
Copy link
Member Author

Merging.

@jbrooksuk jbrooksuk merged commit eb19cf4 into 2.4 Jul 25, 2017
@jbrooksuk jbrooksuk deleted the incident-components branch July 25, 2017 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants