Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Custom Statuses #2643

Closed
wants to merge 2 commits into from
Closed

[WIP] Custom Statuses #2643

wants to merge 2 commits into from

Conversation

jbrooksuk
Copy link
Member

Closes #2051


Not a lot to see here yet. We're creating the statuses table and migrating existing statuses into said table.

Things to do:

  • Think about whether we need to include an order column for each type?
  • Migrate existing incidents.status data into new statuses.id value
  • Drop existing incidents.status column
  • Setup model relationships
  • Update views to use new status value
  • Update API

@jbrooksuk
Copy link
Member Author

Note that the status values will now not be backwards compatible, making this a v3.0 release when the time comes.

@joecohens
Copy link
Contributor

Also doing this the statuses won't be translated automatically, are they?

@jbrooksuk
Copy link
Member Author

Correct. It's a shame because auto translations were nice, but this offers far more benefits.

@jbrooksuk
Copy link
Member Author

Unless we added locale...

@ConnorVG
Copy link
Contributor

Or we can just key the statuses rather than giving them (in the db) full representations. That'll just pass to trans as we sort of do now. Easy win.

This has been a long time coming ❤️

@m1guelpf
Copy link
Contributor

#winterstatusesarecoming

@jbrooksuk
Copy link
Member Author

@ConnorVG what do you mean?

@Geethree
Copy link

Geethree commented Sep 8, 2017

Any updates on this PR? This is the sole feature keeping us from using Catchet...

@jbrooksuk
Copy link
Member Author

@Geethree not yet I'm sorry! Needs more time and thought :)

@Geethree
Copy link

Geethree commented Nov 4, 2017

Waiting.
Hoping.
Wishing.
For custom statuses!

@jbrooksuk
Copy link
Member Author

I promise they'll get here, there's just a lot of stuff to do elsewhere that may change the way this works :)

@Geethree
Copy link

=(

@Geethree
Copy link

Meh. I just overwrote the appropriate lang resource and mounted that in the appropriate location as a docker volume. Perhaps that will work. /shrug

@jbrooksuk
Copy link
Member Author

@Geethree that's really the easiest way to do this if you're comfortable changing Cachet source files 🌈

@jamesrenaud
Copy link

Watching this PR, we had this on a previous system before moving to Cachet and would love to have the same functionality with Cachet

@jbrooksuk
Copy link
Member Author

@JamesrenaudMitel cool. I will pick this up again at some point.

@Geethree
Copy link

Can it be picked up yet?

@Geethree
Copy link

Is there anyway I could help with this issue?

@jbrooksuk
Copy link
Member Author

Note to self. Custom statuses in 3.x!

@jbrooksuk jbrooksuk closed this Aug 12, 2023
@jbrooksuk jbrooksuk deleted the custom-statuses branch August 12, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new component status for ongoing maintenance (e.g. UNDER MAINTENANCE)
6 participants