Bugs in the average metrics graph #2874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When selecting the time of metric's points only the time was selected, not the date. The issue with this is mainly in the view "Last 12 hours". Example: It's 11:10 am and I choose the "Last 12 hours" view, the metrics points will be from 23:00 yesterday to 11:00 am today. When giving all these datas and labels to ChartJS, it sorts the points by label from lower to highter. It means 23:00 (from yesterday) will be after the datas of today, it doesn't have sense. To fix it, I've added in the repositories the date in addition to the time. So it's no longer 11:00 that is selected but 2018-01-15 11:00. I've updated the Metric vue in order to cut the label when displaying so it doesn't change the displaying. Because there are metric views that are based on date but not time, there is a condition in the Metric vue to cut the string only if the time is present. Related to cachethq#2848
When we mouseovered on a point on a metric, the value was shown but the suffix wasn't. It was due to a curly bracket issue, the "tooltip" option wasn't given as an "option" sub-object, but as a third argument of the Chart constructor. A curly bracket was closed to early. This is fixed and the suffix is now displayed. Related to cachethq#2848
The metrics had problem with the points, if I post/save a metric point that is created in the future, it was selected. Example: It is 10:00 am, I post or save a metric point and it's 'created at' 10:30 am. Using the "Last 12 hours" the metric point would be selected. This update is applied on all the SQL queries, on minutes, hours, days. Related to cachethq#2848
Update from upstream repo CachetHQ/Cachet
|
This looks great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems
How they were fixed
AND created_ad < NOW()was added in the different syntaxes for the different repositories in order to filter the future.