-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugs in the average metrics graph #2874
Merged
jbrooksuk
merged 7 commits into
cachethq:2.4
from
uxen-ab:bugs-in-the-average-metrics-graph
Jan 21, 2018
Merged
Bugs in the average metrics graph #2874
jbrooksuk
merged 7 commits into
cachethq:2.4
from
uxen-ab:bugs-in-the-average-metrics-graph
Jan 21, 2018
Commits on Jan 15, 2018
-
Improves sorting of metric's labels.
When selecting the time of metric's points only the time was selected, not the date. The issue with this is mainly in the view "Last 12 hours". Example: It's 11:10 am and I choose the "Last 12 hours" view, the metrics points will be from 23:00 yesterday to 11:00 am today. When giving all these datas and labels to ChartJS, it sorts the points by label from lower to highter. It means 23:00 (from yesterday) will be after the datas of today, it doesn't have sense. To fix it, I've added in the repositories the date in addition to the time. So it's no longer 11:00 that is selected but 2018-01-15 11:00. I've updated the Metric vue in order to cut the label when displaying so it doesn't change the displaying. Because there are metric views that are based on date but not time, there is a condition in the Metric vue to cut the string only if the time is present. Related to cachethq#2848
Configuration menu - View commit details
-
Copy full SHA for fc2e6f4 - Browse repository at this point
Copy the full SHA fc2e6f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for c11626a - Browse repository at this point
Copy the full SHA c11626aView commit details -
Display the metric's suffix in tooltip.
When we mouseovered on a point on a metric, the value was shown but the suffix wasn't. It was due to a curly bracket issue, the "tooltip" option wasn't given as an "option" sub-object, but as a third argument of the Chart constructor. A curly bracket was closed to early. This is fixed and the suffix is now displayed. Related to cachethq#2848
Configuration menu - View commit details
-
Copy full SHA for 0f6512f - Browse repository at this point
Copy the full SHA 0f6512fView commit details -
Prevents to select metric points in future.
The metrics had problem with the points, if I post/save a metric point that is created in the future, it was selected. Example: It is 10:00 am, I post or save a metric point and it's 'created at' 10:30 am. Using the "Last 12 hours" the metric point would be selected. This update is applied on all the SQL queries, on minutes, hours, days. Related to cachethq#2848
Configuration menu - View commit details
-
Copy full SHA for d8208be - Browse repository at this point
Copy the full SHA d8208beView commit details
Commits on Jan 16, 2018
-
Merge pull request #3 from CachetHQ/2.4
Update from upstream repo CachetHQ/Cachet
Configuration menu - View commit details
-
Copy full SHA for d5b93da - Browse repository at this point
Copy the full SHA d5b93daView commit details
Commits on Jan 17, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 64bf42a - Browse repository at this point
Copy the full SHA 64bf42aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9af7978 - Browse repository at this point
Copy the full SHA 9af7978View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.