Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the mail username optional in setup #3294

Merged
merged 2 commits into from
Dec 29, 2018
Merged

Set the mail username optional in setup #3294

merged 2 commits into from
Dec 29, 2018

Commits on Dec 28, 2018

  1. Set the mail username optional in setup 

    During the setup process email informations were asked:
  - Driver
  - Host
  - Username
  - Password

In some situations the username is not useful because the Cachet's
host may be configured to forward email to a server.

The problem is the username was required, so we had to set a username
and then update the .env file to remove it.

To fix this problem, the mail username has been set to optional in
the setup. So if someone needs a username it still can use this field,
and otherwise people can let it empty.

See: cachethq#3244
    @nalysius
    nalysius committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    c9bc2f5 View commit details
    Browse the repository at this point in the history

  2. Let the mail_username required except for sendmail 

    During the setup the "mail_username" was required and it was then
undone, so using the sendmail driver we can let the username empty.

It would be bad to let the username optional for every drivers, because
in some configurations, like SMTP, the username is required for the SMTP
server so if the user let it empty its mail configuration will be bad.

The mail_username is now optional only if the mail driver is sendmail.

See: cachethq#3244
    @nalysius
    nalysius committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    cecf894 View commit details
    Browse the repository at this point in the history