Set the mail username optional in setup #3294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalysius
changed the title
|
I've updated the SetupController, but I've to change because for now if |
|
@anthonybocci did we not change the subscriber test to simply be whether the setting is enabled or not? |
During the setup process email informations were asked: - Driver - Host - Username - Password In some situations the username is not useful because the Cachet's host may be configured to forward email to a server. The problem is the username was required, so we had to set a username and then update the .env file to remove it. To fix this problem, the mail username has been set to optional in the setup. So if someone needs a username it still can use this field, and otherwise people can let it empty. See: cachethq#3244
nalysius
force-pushed
the
setup-requires-username-3244
branch
from
26cf631
to
c9bc2f5
Compare
During the setup the "mail_username" was required and it was then undone, so using the sendmail driver we can let the username empty. It would be bad to let the username optional for every drivers, because in some configurations, like SMTP, the username is required for the SMTP server so if the user let it empty its mail configuration will be bad. The mail_username is now optional only if the mail driver is sendmail. See: cachethq#3244
|
@jbrooksuk I just checked, your right the test has been updated. |
|
Okay, cool! I’m on my phone but I think this can be updated from WIP and then merged. |
nalysius
changed the title
|
@jbrooksuk I've removed the "WIP", you can check (because I'm not familiar with the Laravel validator) :) |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the setup process email informations were asked:
In some situations the username is not useful because the Cachet's
host may be configured to forward email to a server.
The problem is the username was required, so we had to set a username
and then update the .env file to remove it.
To fix this problem, the mail username has been set to optional in
the setup. So if someone needs a username it still can use this field,
and otherwise people can let it empty.
See: #3244