Patching manage subscription #3423
Conversation
Fix a incident name issue
Remove slack unsubscribe
Eding manage button for subscription
Adding manage route
enableSubscribers is used for Signup on the main dashboard, but cannot be forced for Admin on control
Existing subscription user should be able to manage his setting without considering if he is allowed to subscribe or not.
|
@AntonioKL do you know if #3431 superseded this on purpose? |
Can you please explain? Not sure what do you mean? |
|
The linked PR has some of the same code as this branch? |
3431 is about GDRP , not sure how it is relevant for subscription management. This is my own code and I didn't take it from anybody. |
@AntonioKL sorry, I’m not suggesting you copied it, I was just wondering if there is overlap and the other PR addresses both issues? GDPR is closely related to subscriptions, you see. |
Doesn't overlap. |
|
🤔 I just checked again and it doesn't. Sorry, I'm not sure what I'd looked at yesterday. Before this gets merged, we still need to change the middleware, please. |
|
@AntonioKL ah, it's #3422 which has similar files. |
|
@jbrooksuk |
|
Hooray! Your first Pull Request was merged, here's to many more 🚀 |
Existing subscriber should be able to manage his setting without considering if someone is allowed to subscribe or not.