GDPR #3431
GDPR #3431
Conversation
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
|
|
||
| <div class="tab-content"> | ||
| <div role="tabpanel" class="tab-pane active" :id="name"> | ||
| <textarea class="form-control" :name="name" rows="5" v-model="valueModel"></textarea> |
There was a problem hiding this comment.
Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input. If you don't want a visual label, try an aria-label attribute.
the acceptPrivacyStatement parameter is now required in the api endpoint POST /subscribers
There was a problem hiding this comment.
This is great work! Thank you so much for taking this on.
There are just a few things that need addressing:
- Not having a privacy statement should not prevent people to signup. Countries outside of the EU whose customers (whether that's internal or external) don't need to follow GDPR. Also, if Cachet is used internally, then a privacy statement would not be needed.
- The footers in the status page and emails should only link to the Imprint or Privacy Statement if there is one.
- Can we add the Markdown icon to the
textareas as we have done for others? - Please remove the
.gitignorechanges. - Please don't install the Laravel IDE Helper.
- What about HTTP support in URLs?
resources/assets/js/components/dashboard/settings/TextareaWithMarkdownPreview.vue
Outdated
Show resolved
Hide resolved
This reverts commit e2d9ae8.
| <div class="tab-content"> | ||
| <div role="tabpanel" class="tab-pane active" :id="name"> | ||
| <div class="markdown-control"> | ||
| <textarea class="form-control" :name="name" rows="5" v-model="valueModel" :aria-label="label"></textarea> |
There was a problem hiding this comment.
Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input. If you don't want a visual label, try an aria-label attribute.
|
By the way don't worry about StyleCI issues, that'll fix automatically once we merge. Can you remove the compiled assets please. They create way too many conflicts :) |
|
Hi, when will this be added? Companies can be punished to penalties of several thousands of € if a user can't apply to the GDPR !!!!! This is highly important!!! |
|
@gcommit Do not hesitate to contribute to make things happen. 😇 |
|
I will see what i can do. but this is an issue which is urgent because of the laws in europe. It‘s not some small feature request. And this pull request is stuck for a whole year now... |
|
Well this leads to nowhere... I'm closing this pull request and will open another one with the changes rebased on the current 2.4 branch |
This pull request adds a "privacy" tab to the settings page where you can
The privacy statement and imprint links will be displayed on every page in the footer area as well as the footer in all email notifications. (only if the respective setting is not empty) (#3054)
Additionally all subscribers need to accept the privacy statement before being subscribed. (only if the privacy statement is not empty)
All Notification emails now contain an List-Unsubscribe header (#3102)