Allow Cachet setup not to be at server's root #3645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cachet may be installed at the root of its vhost or in a subdirectory, for example in "/" or under "/status". The URI we found pointing to some assets were usually not prefixed with the path, so if Cachet was installed under "/status" the asset URI pointed to the server root like "/my-asset.js". It is a problem because that means the behaviour is broken in this case. The problem was present from the setup, it was not possible to fill the setup since the path to the scripts and CSS weres wrong. The "asset" helper is now used and resolves the URI. See: cachethq#3618
nalysius
force-pushed
the
feature/3618-setup-assets-path
branch
from
513489d
to
fbf141c
Compare
|
Thanks for backporting this to 2.3 too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cachet may be installed at the root of its vhost or in a subdirectory,
for example in "/" or under "/status".
The URI we found pointing to some assets were usually not prefixed with
the path, so if Cachet was installed under "/status" the asset
URI pointed to the server root like "/my-asset.js".
It is a problem because that means the behaviour is broken in this case.
The problem was present from the setup, it was not possible to fill the
setup since the path to the scripts and CSS weres wrong.
The "asset" helper is now used and resolves the URI.
See: #3618