-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Cachet to be setup not from the server's root #3646
Conversation
@anthonybocci, I confirm that css/js/images are now OK (dashboard, status page (connected or anonymous) and setup page) but the fonts path are not fixed: /fonts/ionicons.woff and /fonts/ionicons.ttf doesn't use custom path Thank you! |
link with #3645?
|
@agentcobra yes it's related to #3645. Here I target 2.4 branch, the other PR targets 2.3. |
Hi @anthosz, I checked by loading the setup page, but I don't find any 404 error in my browser. Could you explain me a bit more? |
Hi @anthonybocci Maybe the fonts are not used in setup page, do you have the 404 after setup? (status and dashboard page) |
@anthosz Ok I didn't understood. I'd tested only the setup part. I don't know where the font is included, probably somewhere from the CSS. I'll have a look, thanks for the explanation :) |
Yeah, the fonts are loaded from CSS itself. I'd quite like to remove the icon font and use SVG at some point anyway. I know @ojdon is working on implementing the redesign. |
The `asset()` helper was missing at some places so it was not possible to install it in an other place than the server's root (/). The paths have been fixed and now use the `asset()` helper. Also, The steps process takes care of the current path. See: cachethq#3618
f9977e0
to
67b43ed
Compare
So is the PR mergeable @jbrooksuk? I don't touch the CSS since the design is under work. |
This seems to work locally, thanks @anthonybocci! |
The
asset()
helper was missing at some places so it was not possibleto install it in an other place than the server's root (/).
The paths have been fixed and now use the
asset()
helper. Also,The steps process takes care of the current path.
See: #3618