Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Cachet to be setup not from the server's root #3646

Merged
merged 2 commits into from
Jun 23, 2019

Conversation

nalysius
Copy link
Contributor

@nalysius nalysius commented Jun 8, 2019

The asset() helper was missing at some places so it was not possible
to install it in an other place than the server's root (/).

The paths have been fixed and now use the asset() helper. Also,
The steps process takes care of the current path.

See: #3618

@anthosz
Copy link

anthosz commented Jun 9, 2019

@anthonybocci, I confirm that css/js/images are now OK (dashboard, status page (connected or anonymous) and setup page) but the fonts path are not fixed: /fonts/ionicons.woff and /fonts/ionicons.ttf doesn't use custom path

Thank you!

@agentcobra
Copy link

agentcobra commented Jun 10, 2019 via email

@nalysius
Copy link
Contributor Author

@agentcobra yes it's related to #3645. Here I target 2.4 branch, the other PR targets 2.3.

@nalysius
Copy link
Contributor Author

Hi @anthosz, I checked by loading the setup page, but I don't find any 404 error in my browser. Could you explain me a bit more?
Here is my browser's console when I load /setup:

cachet-setup

@anthosz
Copy link

anthosz commented Jun 13, 2019

Hi @anthonybocci

Maybe the fonts are not used in setup page, do you have the 404 after setup? (status and dashboard page)

@nalysius
Copy link
Contributor Author

@anthosz Ok I didn't understood. I'd tested only the setup part. I don't know where the font is included, probably somewhere from the CSS. I'll have a look, thanks for the explanation :)

@jbrooksuk
Copy link
Member

Yeah, the fonts are loaded from CSS itself. I'd quite like to remove the icon font and use SVG at some point anyway.

I know @ojdon is working on implementing the redesign.

The `asset()` helper was missing at some places so it was not possible
to install it in an other place than the server's root (/).

The paths have been fixed and now use the `asset()` helper. Also,
The steps process takes care of the current path.

See: cachethq#3618
@nalysius nalysius force-pushed the feature/3618-setup-path-2.4 branch from f9977e0 to 67b43ed Compare June 19, 2019 09:19
@nalysius
Copy link
Contributor Author

So is the PR mergeable @jbrooksuk? I don't touch the CSS since the design is under work.

@jbrooksuk jbrooksuk merged commit 76e9f41 into cachethq:2.4 Jun 23, 2019
@jbrooksuk
Copy link
Member

This seems to work locally, thanks @anthonybocci!

@jbrooksuk jbrooksuk added this to the V2.4.0 milestone Jun 23, 2019
@nalysius nalysius deleted the feature/3618-setup-path-2.4 branch June 23, 2019 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants