Tests notifications #3816
Merged
Tests notifications #3816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do the continuous integration checks need actioning? I get some, but the closing brace at the end suggests I just remove and add it again. Is this down to whitespace/line endings? Does this tool autofix when you merge or do I need to do something? |
szepeviktor
reviewed
Nov 11, 2019
| @@ -72,7 +72,7 @@ public function toMail($notifiable) | |||
| $content = trans('notifications.incident.new.mail.content', [ | |||
| 'name' => $this->incident->name, | |||
| ]); | |||
|
|
|||
There was a problem hiding this comment.
@Data-Kiss Could it be a stray space?
|
StyleCI will fix when merged. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a few tests for sending notifications. Will continue to work on this class when I have time, or if anyone else wishes to feel free.