Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests notifications #3816

Merged
merged 4 commits into from
Nov 13, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/Notifications/Incident/NewIncidentNotification.php
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public function toMail($notifiable)
$content = trans('notifications.incident.new.mail.content', [
'name' => $this->incident->name,
]);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Data-Kiss Could it be a stray space?

return (new MailMessage())
->subject(trans('notifications.incident.new.mail.subject'))
->markdown('notifications.incident.new', [
Expand Down
2 changes: 1 addition & 1 deletion resources/lang/en/cachet.php
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
'stickied' => 'Stickied Incidents',
'scheduled' => 'Maintenance',
'scheduled_at' => ', scheduled :timestamp',
'posted' => 'Posted :timestamp',
'posted' => 'Posted :timestamp by :username',
'posted_at' => 'Posted at :timestamp',
'status' => [
1 => 'Investigating',
Expand Down
2 changes: 1 addition & 1 deletion resources/lang/en/dashboard.php
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
'failure' => 'Something went wrong updating the incident update',
],
],
'reported_by' => 'Reported by :user',
'reported_by' => 'Reported :timestamp by :user',
'add' => [
'title' => 'Report an incident',
'success' => 'Incident added.',
Expand Down
2 changes: 1 addition & 1 deletion resources/views/dashboard/incidents/index.blade.php
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
<p>{{ Str::words($incident->message, 5) }}</p>
@endif
@if ($incident->user)
<p><small>&mdash; {{ trans('dashboard.incidents.reported_by', ['user' => $incident->user->username]) }}</small></p>
<p><small>&mdash; {{ trans('dashboard.incidents.reported_by', ['timestamp' => $incident->created_at_diff, 'user' => $incident->user->username]) }}</small></p>
@endif
</div>
<div class="col-xs-6 text-right">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
<div class="row striped-list-item">
<div class="col-xs-6">
<strong>{{ Str::words($update->message, 8) }}</strong>
<p><small>{{ trans('cachet.incidents.posted', ['timestamp' => $update->created_at_diff]) }}</small></p>
<p><small>{{ trans('cachet.incidents.posted', ['timestamp' => $update->created_at_diff, 'username' => $update->user->username]) }}</small></p>
</div>
<div class="col-xs-6 text-right">
<a href="{{ cachet_route('dashboard.incidents.updates.edit', ['incident' => $incident->id, 'incident_update' => $update]) }}" class="btn btn-default">
Expand Down
194 changes: 194 additions & 0 deletions tests/Functional/Notifications/MailTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,194 @@
<?php

/*
* This file is part of Cachet.
*
* (c) Alt Three Services Limited
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace CachetHQ\Tests\Cachet\Functional\Notifications;

use CachetHQ\Cachet\Bus\Commands\Incident\CreateIncidentCommand;
use CachetHQ\Cachet\Bus\Commands\Subscriber\SubscribeSubscriberCommand;
use CachetHQ\Cachet\Models\Incident;
use CachetHQ\Cachet\Models\Subscriber;
use CachetHQ\Cachet\Notifications\Incident\NewIncidentNotification;
use CachetHQ\Cachet\Notifications\IncidentUpdate\IncidentUpdatedNotification;
use CachetHQ\Cachet\Settings\Repository as SettingsRepository;
use CachetHQ\Tests\Cachet\AbstractTestCase;
use Illuminate\Foundation\Testing\DatabaseMigrations;
use Illuminate\Support\Facades\Notification;
use Illuminate\Support\Str;

class MailTest extends AbstractTestCase
{
use DatabaseMigrations;

/**
* @var \Faker\Generator
*/
protected $fakerFactory;

/**
* @var string
*/
protected $appName;

/**
* @var array[]|null
*/
protected $incidents;

/**
* @var string
*/
protected $subscriber;

/**
* MailTest constructor.
*
* @param null $name
* @param array $data
* @param string $dataName
*/
public function __construct($name = null, array $data = [], $dataName = '')
{
parent::__construct($name, $data, $dataName);
$this->fakerFactory = \Faker\Factory::create();
$this->appName = 'MailTest';
}

/**
* Setup the application.
*/
public function setUp()
{
parent::setUp();
$this->app->make(SettingsRepository::class)->set('app_name', $this->appName);
$this->app->config->set('setting.app_name', $this->appName);
$this->incidents = [
['title' => 'Foo '.Str::random(16), 'description' => 'Foo Bar Baz '.Str::random(32)],
['title' => 'Foe '.Str::random(16), 'description' => 'Foe Baz Bar '.Str::random(32)],
];
}

/**
* Create a new subscriber.
*/
public function createSubscriber($subscriberEmail)
{
dispatch(new SubscribeSubscriberCommand(
$subscriberEmail,
true
));

return Subscriber::where('email', '=', $subscriberEmail)->firstOrFail();
}

/**
* @param array $incident
* @param array $meta
*
* @return Incident
*/
protected function createIncident(array $incident)
{
$name = $incident['title'];
$message = $incident['description'];


dispatch(new CreateIncidentCommand(
$name,
$this->fakerFactory->numberBetween(0, 3),
$message,
true,
null,
null,
true,
true,
$this->fakerFactory->date('Y-m-d H:i'),
null,
[]
));

return Incident::where('name', '=', $name)->where('message', '=', $message)->firstOrFail();
}

/**
* Send an email notification to subscribers when a new incident
* is added.
*/
public function testEmailNotificationSentForNewIncident()
{
Notification::fake();

$this->signIn();

$subscriber = $this->createSubscriber($this->fakerFactory->safeEmail);


$response = $this->post('dashboard/incidents/create', [
'name' => $this->fakerFactory->word,
'status' => 1,
'visible' => 1,
'message' => $this->fakerFactory->paragraph,
'notify' => 1
]);

Notification::assertSentTo(
[$subscriber], NewIncidentNotification::class
);
}

/**
* Do not send an email if notify not checked.
*/
public function testEmailNotificationNotSentWhenNotifyNotCheckedForNewIncident()
{
Notification::fake();

$this->signIn();

$subscriber = $this->createSubscriber($this->fakerFactory->safeEmail);

$response = $this->post('dashboard/incidents/create', [
'name' => $this->fakerFactory->word,
'status' => 1,
'visible' => 1,
'message' => $this->fakerFactory->paragraph,
'notify' => 0
]);

Notification::assertNotSentTo(
[$subscriber], NewIncidentNotification::class
);
}

/**
* Send an email notification to subscribers when an incident
* update is added.
*/
public function testEmailNotificationSentForIncidentUpdate()
{
Notification::fake();


$this->signIn();

$incident = $this->createIncident($this->incidents[1]);
$subscriber = $this->createSubscriber($this->fakerFactory->safeEmail);


$response = $this->post('dashboard/incidents/'.$incident->id.'/updates/create', [
'status' => 1,
'message' => $this->fakerFactory->paragraph,
]);

Notification::assertSentTo(
[$subscriber], IncidentUpdatedNotification::class
);
}
}