Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code unification #103

Merged
merged 8 commits into from
Aug 29, 2023
Merged

Code unification #103

merged 8 commits into from
Aug 29, 2023

Conversation

tleef42
Copy link
Contributor

@tleef42 tleef42 commented Aug 22, 2023

Set to be merged onto #96 to ensure this branch is merged last as it modifies code all other branches currently have (base can be changed from af176-hashes to main after all other pull requests have been merged)

Standardized the code in the validator:

  • Added missing semi-colons
  • Converting if() conditions to match the switch cases
  • Removing String() conversions to use built-in functions

@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
37.3% 37.3% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Base automatically changed from af176-hashes to main August 23, 2023 14:44
@mikecarenzo mikecarenzo merged commit 781d683 into main Aug 29, 2023
1 of 2 checks passed
@mikecarenzo mikecarenzo deleted the code-cleanup branch August 29, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants