Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AF-176: Hashes #96

Merged
merged 6 commits into from
Aug 23, 2023
Merged

AF-176: Hashes #96

merged 6 commits into from
Aug 23, 2023

Conversation

tleef42
Copy link
Contributor

@tleef42 tleef42 commented Aug 9, 2023

This PR should be merged after #98 and #97

Hashes need to be published as objects with specific naming conventions for hash type.
Biggest change was that Hashes format is:

  • ListProperty
    • DictionaryProperty
      • hash_type: EnumProperty
      • hash_value: StringProperty

Hashes needs to be published as one single Object so a new method had to be created since mergeBasicListProperty exports only a single value and Hashes can contain multiple.

This was breaking the build process because of no backwards compatibility for older .AFB files, this should produce warnings to tell users that they need to update their flows (attached to each Hash-having object that throws a warning)

This was referenced Aug 9, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 19, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
45.9% 45.9% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@tleef42 tleef42 marked this pull request as ready for review August 19, 2023 20:36
@tleef42 tleef42 mentioned this pull request Aug 22, 2023
@mikecarenzo mikecarenzo merged commit f7debc3 into main Aug 23, 2023
@mikecarenzo mikecarenzo deleted the af176-hashes branch August 23, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants