Connectors v1 #16
Merged
Connectors v1 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilinzweilin
changed the title
AStox
reviewed
Aug 19, 2022
AStox
reviewed
Aug 19, 2022
hieronx
reviewed
Aug 19, 2022
…ction for testing.
Closed
5 tasks
hieronx
reviewed
Jan 26, 2023
Use a cent-chain generated message to test AddTranche encoding and decoding functions.
* Use cent-chain generated UpdateMember for decoding * Drop toBytes16
* wip: add transfer test * move memberlist check from connectors to restricted token * fix tests * revert restricted.sol changes * revert unwanted changes to erc20 and memberlist * fix test
* remove domainLookup * require destination domain to be cent chain * fix tests * clean up * fix up * rename Domains to Domain * Add new domain lookup * update domain enum * move formatDomain to messages.sol * fix tests * update enum and domain encoding * update domain encoding to output bytes9 * Update src/Connector.sol * update domain encoding and add more tests --------- Co-authored-by: Jeroen Offerijns <[email protected]>
AStox
previously approved these changes
Feb 7, 2023
* Fix transfer encoding / decoding We need to encode address as 32 bytes and take in consideration when decoding. Also, amount should be encoded as a u128. * Fix transfer decoding * Cover transfer to centrifuge * Fix docs - thanks @AStox
AStox
previously approved these changes
Feb 8, 2023
hieronx
reviewed
Feb 8, 2023
| uint64 poolId, | ||
| bytes16 trancheId, | ||
| address user, | ||
| uint256 amount | ||
| ) public onlyRouter { | ||
| RestrictedTokenLike token = RestrictedTokenLike(tranches[poolId][trancheId].token); | ||
| require(address(token) != address(0), "CentrifugeConnector/unknown-token"); | ||
| require(token.hasMember(user), "CentrifugeConnector/not-a-member"); |
There was a problem hiding this comment.
Bumping this ^ @NunoAlexandre @AStox
hieronx
reviewed
Feb 9, 2023
| uint64 poolId, | ||
| bytes16 trancheId, | ||
| address user, | ||
| uint256 amount | ||
| ) public onlyRouter { | ||
| RestrictedTokenLike token = RestrictedTokenLike(tranches[poolId][trancheId].token); | ||
| require(address(token) != address(0), "CentrifugeConnector/unknown-token"); | ||
| require(token.hasMember(user), "CentrifugeConnector/not-a-member"); |
There was a problem hiding this comment.
Gotcha. I would keep it like this for now, to not change the existing restricted token implementation. But let's discuss this a bit more and we can still change it in V2 optionally.
NunoAlexandre
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To Do
Messages.t.sol@NunoAlexandredomainto theTransfermessage - see Connectors v1 #16 (comment) @AStox