Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connectors v1 #16
Connectors v1 #16
Changes from 13 commits
e7b05c4
ff49895
1ab18a8
ddf1023
40049f6
d98626e
f32024b
ed9515f
2ed1b5a
b1284e0
47ec66f
abc64b2
fd2ecde
335820c
d45f17e
3cb96e8
71d553a
e1cfc14
2e47470
8338a3b
33a8191
1c57fa7
65ed9bb
6593be2
7da41b5
84c7f39
8fe2b8b
644dbb2
7f3870b
827797c
e2f01b2
a6d8f58
c8d6c3b
1a287d9
f744dd2
e2832fe
2d91780
afb740c
2ae621d
d1898d8
aa41811
78edd87
8a20e95
54dd4bb
695f1f0
0b28d84
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a test for this already, i.e. testing that a transfer to a non-whitelisted address fails? I think this check is actually redundant as the underlying erc20 token already checks that the destination address is a member.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumping this ^ @NunoAlexandre @AStox
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minting doesn't check the memberlist. This was the change I had made to
restricted.sol
, since it seems kind of odd that a permissioned token can mint to any addressThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha. I would keep it like this for now, to not change the existing restricted token implementation. But let's discuss this a bit more and we can still change it in V2 optionally.