Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing Karma with Web Test Runner #1546

Merged
merged 10 commits into from
Oct 23, 2023
Merged

Replacing Karma with Web Test Runner #1546

merged 10 commits into from
Oct 23, 2023

Conversation

koddsson
Copy link
Member

@koddsson koddsson commented Oct 21, 2023 •
edited
Loading

Web Test Runner is a pretty good test runner that runs tests in browsers and a good replacement for Karma.

@koddsson koddsson requested a review from a team as a code owner October 21, 2023 19:53
@koddsson koddsson marked this pull request as draft October 21, 2023 19:53
@koddsson koddsson changed the title [WIP] Replacing Karma with Web Test Runner Replacing Karma with Web Test Runner Oct 21, 2023
43081j
43081j reviewed Oct 22, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@koddsson
Copy link
Member Author

Looks like Safari has some nonstandard sourceURL property that's showing up in the AssertionError. Looking into this.

@koddsson koddsson mentioned this pull request Oct 23, 2023
Closed
@koddsson
Copy link
Member Author

I actually just dropped checking in Safari. These issues also exist on branch 5.x.x but it looks like we've never tested in Safari before. Since WebKit uses a different standard than V8 we'd need to normalise the stack trace somehow but I'd say that it's out of scope for this work.

Reference: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/stack

@koddsson koddsson marked this pull request as ready for review October 23, 2023 09:41
@koddsson koddsson merged commit 0fc290b into chaijs:5.x.x Oct 23, 2023
5 checks passed
@koddsson koddsson deleted the web-test-runner branch October 23, 2023 12:48
@koddsson koddsson mentioned this pull request Oct 24, 2023
Closed
This was referenced May 26, 2024
Open
Closed
@lholmquist lholmquist mentioned this pull request May 30, 2024
Closed
@taeb3 taeb3 mentioned this pull request May 31, 2024
Open
@anand-py anand-py mentioned this pull request Jun 2, 2024
Open
This was referenced Jul 22, 2024
Open
Open
Open
Open
@OKEAMAH OKEAMAH mentioned this pull request Jul 23, 2024
Merged
This was referenced Jul 23, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
@dlminvestments dlminvestments mentioned this pull request Jul 25, 2024
Open
This was referenced Jul 26, 2024
Open
Open
@LLotme LLotme mentioned this pull request Jul 27, 2024
Merged
This was referenced Jul 27, 2024
Open
Open
Open
Open
Open
This was referenced Aug 1, 2024
Open
Open
This was referenced Aug 16, 2024
Open
Open
Open
Merged
solaris007 added a commit to adobe/spacecat-shared that referenced this pull request Aug 27, 2024
@renovate @solaris007
chore(deps): update external major (major) (#346)
7a48f16 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change | Age | Adoption | Passing |
Confidence |
|---|---|---|---|---|---|---|---|
| [actions/setup-java](https://github.com/actions/setup-java) | action
| major | `v3` -> `v4` |
[![age](https://developer.mend.io/api/mc/badges/age/github-tags/actions%2fsetup-java/v4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/github-tags/actions%2fsetup-java/v4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/github-tags/actions%2fsetup-java/v3/v4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/github-tags/actions%2fsetup-java/v3/v4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [chai](http://chaijs.com) ([source](https://github.com/chaijs/chai))
| devDependencies | major | [`4.5.0` ->
`5.1.1`](https://renovatebot.com/diffs/npm/chai/4.5.0/5.1.1) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/chai/5.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/chai/5.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/chai/4.5.0/5.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/chai/4.5.0/5.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>actions/setup-java (actions/setup-java)</summary>

### [`v4`](https://github.com/actions/setup-java/compare/v3...v4)

[Compare
Source](https://github.com/actions/setup-java/compare/v3...v4)

</details>

<details>
<summary>chaijs/chai (chai)</summary>

### [`v5.1.1`](https://github.com/chaijs/chai/releases/tag/v5.1.1)

[Compare
Source](https://github.com/chaijs/chai/compare/v5.1.0...v5.1.1)

#### What's Changed

- Set up ESLint for JSDoc comments by
[@&#8203;koddsson](https://github.com/koddsson) in
[chaijs/chai#1605
- build(deps-dev): bump ip from 1.1.8 to 1.1.9 by
[@&#8203;dependabot](https://github.com/dependabot) in
[chaijs/chai#1608
- Correct Mocha import instructions by
[@&#8203;MattiSG](https://github.com/MattiSG) in
[chaijs/chai#1611
- fix: support some virtual contexts in `toThrow` by
[@&#8203;43081j](https://github.com/43081j) in
[chaijs/chai#1609

#### New Contributors

- [@&#8203;MattiSG](https://github.com/MattiSG) made their first
contribution in
[chaijs/chai#1611

**Full Changelog**:
chaijs/chai@v5.1.0...v5.1.1

### [`v5.1.0`](https://github.com/chaijs/chai/releases/tag/v5.1.0)

[Compare
Source](https://github.com/chaijs/chai/compare/v5.0.3...v5.1.0)

#### What's Changed

- Remove useless guards and add parentheses to constuctors by
[@&#8203;koddsson](https://github.com/koddsson) in
[chaijs/chai#1593
- Cleanup jsdoc comments by
[@&#8203;koddsson](https://github.com/koddsson) in
[chaijs/chai#1596
- Convert comments in "legal comments" format to jsdoc or normal
comments by [@&#8203;koddsson](https://github.com/koddsson) in
[chaijs/chai#1598
- Implement `iterable` assertion by
[@&#8203;koddsson](https://github.com/koddsson) in
[chaijs/chai#1592
- Assert interface fix by
[@&#8203;developer-bandi](https://github.com/developer-bandi) in
[chaijs/chai#1601
- Set support in same members by
[@&#8203;koddsson](https://github.com/koddsson) in
[chaijs/chai#1583
- Fix publish script by
[@&#8203;koddsson](https://github.com/koddsson) in
[chaijs/chai#1602

#### New Contributors

- [@&#8203;developer-bandi](https://github.com/developer-bandi) made
their first contribution in
[chaijs/chai#1601

**Full Changelog**:
chaijs/chai@v5.0.3...v5.1.0

### [`v5.0.3`](https://github.com/chaijs/chai/releases/tag/v5.0.3)

[Compare
Source](https://github.com/chaijs/chai/compare/v5.0.2...v5.0.3)

Fix bad v5.0.2 publish.

**Full Changelog**:
chaijs/chai@v5.0.2...v5.0.3

### [`v5.0.2`](https://github.com/chaijs/chai/releases/tag/v5.0.2)

[Compare
Source](https://github.com/chaijs/chai/compare/v5.0.0...v5.0.2)

#### What's Changed

- build(deps): bump nanoid and mocha by
[@&#8203;dependabot](https://github.com/dependabot) in
[chaijs/chai#1558
- remove `bump-cli` by [@&#8203;koddsson](https://github.com/koddsson)
in
[chaijs/chai#1559
- Update developer dependencies by
[@&#8203;koddsson](https://github.com/koddsson) in
[chaijs/chai#1560
- fix: removes `??` for node compat (5.x) by
[@&#8203;43081j](https://github.com/43081j) in
[chaijs/chai#1576
- Update `loupe` to latest version by
[@&#8203;koddsson](https://github.com/koddsson) in
[chaijs/chai#1579
- Re-enable some webkit tests by
[@&#8203;koddsson](https://github.com/koddsson) in
[chaijs/chai#1580
- Remove a bunch of if statements in test/should.js by
[@&#8203;koddsson](https://github.com/koddsson) in
[chaijs/chai#1581
- Remove a bunch of unused files by
[@&#8203;koddsson](https://github.com/koddsson) in
[chaijs/chai#1582
- Fix 1564 by [@&#8203;koddsson](https://github.com/koddsson) in
[chaijs/chai#1566

**Full Changelog**:
chaijs/chai@v5.0.1...v5.0.2

### [`v5.0.0`](https://github.com/chaijs/chai/releases/tag/v5.0.0)

[Compare
Source](https://github.com/chaijs/chai/compare/v4.5.0...v5.0.0)

#### BREAKING CHANGES

- Chai now only supports EcmaScript Modules (ESM). This means your tests
will need to either have `import {...} from 'chai'` or `import('chai')`.
`require('chai')` will cause failures in nodejs. If you're using ESM and
seeing failures, it may be due to a bundler or transpiler which is
incorrectly converting import statements into require calls.
-   Dropped support for Internet Explorer.
-   Dropped support for NodeJS < 18.
- Minimum supported browsers are now Firefox 100, Safari 14.1, Chrome
100, Edge 100. Support for browsers prior to these versions is "best
effort" (bug reports on older browsers will be assessed individually and
may be marked as wontfix).

#### What's Changed

- feat: use chaijs/loupe for inspection by
[@&#8203;pcorpet](https://github.com/pcorpet) in
[chaijs/chai#1401
- docs: fix URL in README by [@&#8203;Izzur](https://github.com/Izzur)
in
[chaijs/chai#1413
- Remove `get-func-name` dependency by
[@&#8203;koddsson](https://github.com/koddsson) in
[chaijs/chai#1416
- Convert Makefile script to npm scripts by
[@&#8203;koddsson](https://github.com/koddsson) in
[chaijs/chai#1424
- Clean up README badges by
[@&#8203;koddsson](https://github.com/koddsson) in
[chaijs/chai#1422
- fix: package.json - deprecation warning on exports field by
[@&#8203;stevenjoezhang](https://github.com/stevenjoezhang) in
[chaijs/chai#1400
- fix: deep-eql bump package to support symbols by
[@&#8203;snewcomer](https://github.com/snewcomer) in
[chaijs/chai#1458
- ES module conversion PoC by
[@&#8203;43081j](https://github.com/43081j) in
[chaijs/chai#1498
- chore: drop commonjs support by
[@&#8203;43081j](https://github.com/43081j) in
[chaijs/chai#1503
- Update pathval by [@&#8203;koddsson](https://github.com/koddsson) in
[chaijs/chai#1527
- Update check-error by
[@&#8203;koddsson](https://github.com/koddsson) in
[chaijs/chai#1528
- update `deep-eql` to latest version by
[@&#8203;koddsson](https://github.com/koddsson) in
[chaijs/chai#1542
- Inline `type-detect` as a simple function by
[@&#8203;koddsson](https://github.com/koddsson) in
[chaijs/chai#1544
- Update loupe by [@&#8203;koddsson](https://github.com/koddsson) in
[chaijs/chai#1545
- Typo 'Test an object' not 'Test and object' by
[@&#8203;mavaddat](https://github.com/mavaddat) in
[chaijs/chai#1460
- Update `assertion-error` to it's latest major version! by
[@&#8203;koddsson](https://github.com/koddsson) in
[chaijs/chai#1543
- Replacing Karma with Web Test Runner by
[@&#8203;koddsson](https://github.com/koddsson) in
[chaijs/chai#1546

#### New Contributors

- [@&#8203;Izzur](https://github.com/Izzur) made their first
contribution in
[chaijs/chai#1413
- [@&#8203;stevenjoezhang](https://github.com/stevenjoezhang) made
their first contribution in
[chaijs/chai#1400
- [@&#8203;43081j](https://github.com/43081j) made their first
contribution in
[chaijs/chai#1498

**Full Changelog**:
chaijs/chai@4.3.1...v5.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 2pm on Monday" in timezone
Europe/Zurich, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job
log](https://developer.mend.io/github/adobe/spacecat-shared).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Dominique Jäggi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithamus keithamus keithamus approved these changes

@43081j 43081j Awaiting requested review from 43081j

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@koddsson @keithamus @43081j