Set support in same members #1583

koddsson · 2024-01-26T21:42:13Z

Add Set support to members/sameMembers. While doing that I want to introduce a iterable assertion that I think could be useful.

43081j · 2024-01-27T13:06:51Z

should we try support all iterables? may be possible by looking for Symbol.iterator? 🤔

just wondering if we want it to support something which isn't a set or array but is iterable

keithamus · 2024-01-27T13:55:52Z

I think supporting iterators generally is a good idea. Otherwise though this is a good step forward.

koddsson · 2024-01-27T14:51:51Z

should we try support all iterables? may be possible by looking for Symbol.iterator? 🤔

just wondering if we want it to support something which isn't a set or array but is iterable

I think supporting iterators generally is a good idea. Otherwise though this is a good step forward.

Yes! I wanted to change this:

https://github.com/chaijs/chai/pull/1583/files#diff-e3056660026d4431cbb909136ea4290116f5f8be089125a67d6e9ba8f364402dR3145-R3151

to new Assertion(obj, flagMsg, ssfi, true).to.be.an('iterable'); but ran into issues so I'm coming back to it.

koddsson · 2024-01-27T14:56:33Z

Something that I found is that string has Symbol.iterator so there might be some edge-cases.

lib/chai/core/assertions.js

keithamus · 2024-01-27T20:08:22Z

lib/chai/core/assertions.js

@@ -3136,26 +3142,29 @@ function isSubsetOf(_subset, _superset, cmp, contains, ordered) {
 * @api public
 */

-Assertion.addMethod('members', function (subset, msg) {
+Assertion.addMethod('iterable', function(msg) {


👍 this is good

koddsson · 2024-01-28T16:20:29Z

I was gonna point this PR to #1592 but I guess I can't because it's on a different remote. In any case, I split out the iterable assertion into it's own PR which I think we should merge first and then land this fix.

koddsson · 2024-02-11T11:05:41Z

I think this is good but might benefit from more tests.

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---|---|---| | [actions/setup-java](https://github.com/actions/setup-java) | action | major | `v3` -> `v4` | [![age](https://developer.mend.io/api/mc/badges/age/github-tags/actions%2fsetup-java/v4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/github-tags/actions%2fsetup-java/v4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/github-tags/actions%2fsetup-java/v3/v4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/github-tags/actions%2fsetup-java/v3/v4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [chai](http://chaijs.com) ([source](https://github.com/chaijs/chai)) | devDependencies | major | [`4.5.0` -> `5.1.1`](https://renovatebot.com/diffs/npm/chai/4.5.0/5.1.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/chai/5.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/chai/5.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/chai/4.5.0/5.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/chai/4.5.0/5.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>actions/setup-java (actions/setup-java)</summary> ### [`v4`](https://github.com/actions/setup-java/compare/v3...v4) [Compare Source](https://github.com/actions/setup-java/compare/v3...v4) </details> <details> <summary>chaijs/chai (chai)</summary> ### [`v5.1.1`](https://github.com/chaijs/chai/releases/tag/v5.1.1) [Compare Source](https://github.com/chaijs/chai/compare/v5.1.0...v5.1.1) #### What's Changed - Set up ESLint for JSDoc comments by [@koddsson](https://github.com/koddsson) in [chaijs/chai#1605 - build(deps-dev): bump ip from 1.1.8 to 1.1.9 by [@dependabot](https://github.com/dependabot) in [chaijs/chai#1608 - Correct Mocha import instructions by [@MattiSG](https://github.com/MattiSG) in [chaijs/chai#1611 - fix: support some virtual contexts in `toThrow` by [@43081j](https://github.com/43081j) in [chaijs/chai#1609 #### New Contributors - [@MattiSG](https://github.com/MattiSG) made their first contribution in [chaijs/chai#1611 **Full Changelog**: chaijs/chai@v5.1.0...v5.1.1 ### [`v5.1.0`](https://github.com/chaijs/chai/releases/tag/v5.1.0) [Compare Source](https://github.com/chaijs/chai/compare/v5.0.3...v5.1.0) #### What's Changed - Remove useless guards and add parentheses to constuctors by [@koddsson](https://github.com/koddsson) in [chaijs/chai#1593 - Cleanup jsdoc comments by [@koddsson](https://github.com/koddsson) in [chaijs/chai#1596 - Convert comments in "legal comments" format to jsdoc or normal comments by [@koddsson](https://github.com/koddsson) in [chaijs/chai#1598 - Implement `iterable` assertion by [@koddsson](https://github.com/koddsson) in [chaijs/chai#1592 - Assert interface fix by [@developer-bandi](https://github.com/developer-bandi) in [chaijs/chai#1601 - Set support in same members by [@koddsson](https://github.com/koddsson) in [chaijs/chai#1583 - Fix publish script by [@koddsson](https://github.com/koddsson) in [chaijs/chai#1602 #### New Contributors - [@developer-bandi](https://github.com/developer-bandi) made their first contribution in [chaijs/chai#1601 **Full Changelog**: chaijs/chai@v5.0.3...v5.1.0 ### [`v5.0.3`](https://github.com/chaijs/chai/releases/tag/v5.0.3) [Compare Source](https://github.com/chaijs/chai/compare/v5.0.2...v5.0.3) Fix bad v5.0.2 publish. **Full Changelog**: chaijs/chai@v5.0.2...v5.0.3 ### [`v5.0.2`](https://github.com/chaijs/chai/releases/tag/v5.0.2) [Compare Source](https://github.com/chaijs/chai/compare/v5.0.0...v5.0.2) #### What's Changed - build(deps): bump nanoid and mocha by [@dependabot](https://github.com/dependabot) in [chaijs/chai#1558 - remove `bump-cli` by [@koddsson](https://github.com/koddsson) in [chaijs/chai#1559 - Update developer dependencies by [@koddsson](https://github.com/koddsson) in [chaijs/chai#1560 - fix: removes `??` for node compat (5.x) by [@43081j](https://github.com/43081j) in [chaijs/chai#1576 - Update `loupe` to latest version by [@koddsson](https://github.com/koddsson) in [chaijs/chai#1579 - Re-enable some webkit tests by [@koddsson](https://github.com/koddsson) in [chaijs/chai#1580 - Remove a bunch of if statements in test/should.js by [@koddsson](https://github.com/koddsson) in [chaijs/chai#1581 - Remove a bunch of unused files by [@koddsson](https://github.com/koddsson) in [chaijs/chai#1582 - Fix 1564 by [@koddsson](https://github.com/koddsson) in [chaijs/chai#1566 **Full Changelog**: chaijs/chai@v5.0.1...v5.0.2 ### [`v5.0.0`](https://github.com/chaijs/chai/releases/tag/v5.0.0) [Compare Source](https://github.com/chaijs/chai/compare/v4.5.0...v5.0.0) #### BREAKING CHANGES - Chai now only supports EcmaScript Modules (ESM). This means your tests will need to either have `import {...} from 'chai'` or `import('chai')`. `require('chai')` will cause failures in nodejs. If you're using ESM and seeing failures, it may be due to a bundler or transpiler which is incorrectly converting import statements into require calls. - Dropped support for Internet Explorer. - Dropped support for NodeJS < 18. - Minimum supported browsers are now Firefox 100, Safari 14.1, Chrome 100, Edge 100. Support for browsers prior to these versions is "best effort" (bug reports on older browsers will be assessed individually and may be marked as wontfix). #### What's Changed - feat: use chaijs/loupe for inspection by [@pcorpet](https://github.com/pcorpet) in [chaijs/chai#1401 - docs: fix URL in README by [@Izzur](https://github.com/Izzur) in [chaijs/chai#1413 - Remove `get-func-name` dependency by [@koddsson](https://github.com/koddsson) in [chaijs/chai#1416 - Convert Makefile script to npm scripts by [@koddsson](https://github.com/koddsson) in [chaijs/chai#1424 - Clean up README badges by [@koddsson](https://github.com/koddsson) in [chaijs/chai#1422 - fix: package.json - deprecation warning on exports field by [@stevenjoezhang](https://github.com/stevenjoezhang) in [chaijs/chai#1400 - fix: deep-eql bump package to support symbols by [@snewcomer](https://github.com/snewcomer) in [chaijs/chai#1458 - ES module conversion PoC by [@43081j](https://github.com/43081j) in [chaijs/chai#1498 - chore: drop commonjs support by [@43081j](https://github.com/43081j) in [chaijs/chai#1503 - Update pathval by [@koddsson](https://github.com/koddsson) in [chaijs/chai#1527 - Update check-error by [@koddsson](https://github.com/koddsson) in [chaijs/chai#1528 - update `deep-eql` to latest version by [@koddsson](https://github.com/koddsson) in [chaijs/chai#1542 - Inline `type-detect` as a simple function by [@koddsson](https://github.com/koddsson) in [chaijs/chai#1544 - Update loupe by [@koddsson](https://github.com/koddsson) in [chaijs/chai#1545 - Typo 'Test an object' not 'Test and object' by [@mavaddat](https://github.com/mavaddat) in [chaijs/chai#1460 - Update `assertion-error` to it's latest major version! by [@koddsson](https://github.com/koddsson) in [chaijs/chai#1543 - Replacing Karma with Web Test Runner by [@koddsson](https://github.com/koddsson) in [chaijs/chai#1546 #### New Contributors - [@Izzur](https://github.com/Izzur) made their first contribution in [chaijs/chai#1413 - [@stevenjoezhang](https://github.com/stevenjoezhang) made their first contribution in [chaijs/chai#1400 - [@43081j](https://github.com/43081j) made their first contribution in [chaijs/chai#1498 **Full Changelog**: chaijs/chai@4.3.1...v5.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 2pm on Monday" in timezone Europe/Zurich, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/adobe/spacecat-shared).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dominique Jäggi <[email protected]>

koddsson commented Jan 27, 2024

View reviewed changes

lib/chai/core/assertions.js Show resolved Hide resolved

koddsson commented Jan 27, 2024

View reviewed changes

lib/chai/core/assertions.js Outdated Show resolved Hide resolved

koddsson commented Jan 27, 2024

View reviewed changes

lib/chai/core/assertions.js Outdated Show resolved Hide resolved

koddsson commented Jan 27, 2024

View reviewed changes

lib/chai/core/assertions.js Outdated Show resolved Hide resolved

keithamus reviewed Jan 27, 2024

View reviewed changes

koddsson mentioned this pull request Jan 28, 2024

Implement iterable assertion #1592

Merged

koddsson force-pushed the set-support-in-same-members branch from 2219136 to a00c9e2 Compare January 28, 2024 16:18

koddsson added 7 commits February 11, 2024 11:44

Implement iterator assertion

7609580

Move JSDoc to it's function

867230d

Add support for Sets in members assertion

8891064

Add sameMembers test for Set

1a21d15

Update tests

e11306b

Implement iterable assertion

df9485c

Change iterable implementation to a property

393e2ea

koddsson force-pushed the set-support-in-same-members branch from a00c9e2 to 393e2ea Compare February 11, 2024 10:44

koddsson added 2 commits February 11, 2024 11:55

Make changes after merging

d3a37bf

Add more tests for members equality

ca21b17

koddsson marked this pull request as ready for review February 11, 2024 11:05

koddsson requested a review from a team as a code owner February 11, 2024 11:05

keithamus approved these changes Feb 11, 2024

View reviewed changes

koddsson merged commit 1ba37b5 into chaijs:main Feb 12, 2024
5 checks passed

koddsson deleted the set-support-in-same-members branch February 12, 2024 12:32

ggrossetie mentioned this pull request Apr 30, 2024

Update all dependencies asciidoctor/asciidoctor-browser-extension#638

Open

1 task

OKEAMAH mentioned this pull request May 26, 2024

[Snyk] Upgrade chai from 4.4.1 to 5.1.0 OKEAMAH/remix-project#13

Open

This was referenced Jul 22, 2024

[Snyk] Upgrade chai from 4.4.1 to 5.1.1 WontonSam/Bekki13-cloud-node#1763

Open

[Snyk] Upgrade chai from 4.4.1 to 5.1.1 WontonSam/Bekki13-cloud-node#1766

Open

OKEAMAH mentioned this pull request Jul 23, 2024

[Snyk] Upgrade chai from 4.4.1 to 5.1.1 OKEAMAH/optimism#51

Merged

mechanicalpete mentioned this pull request Jul 24, 2024

[Snyk] Upgrade chai from 5.0.3 to 5.1.1 mechanicalpete/serverless-to-observerless#99

Merged

This was referenced Jul 25, 2024

[Snyk] Upgrade chai from 4.4.1 to 5.1.1 WontonSam/Bekki13-cloud-node#2058

Open

[Snyk] Upgrade chai from 4.4.1 to 5.1.1 WontonSam/Bekki13-cloud-node#2062

Open

[Snyk] Upgrade chai from 4.4.1 to 5.1.1 WontonSam/Bekki13-cloud-node#2083

Open

dlminvestments mentioned this pull request Jul 25, 2024

[Snyk] Upgrade chai from 4.5.0 to 5.1.1 dlminvestments/sample-cloud-native-toolchain-tutorial-20190912060014890#120

Open

This was referenced Jul 26, 2024

[Snyk] Upgrade chai from 4.5.0 to 5.1.1 WontonSam/Bekki13-cloud-node#2162

Open

[Snyk] Upgrade chai from 4.5.0 to 5.1.1 WontonSam/Bekki13-cloud-node#2223

Open

LLotme mentioned this pull request Jul 27, 2024

[Snyk] Upgrade chai from 4.3.4 to 5.1.1 LLotme/vscode-dotnet-runtime#54

Merged

This was referenced Aug 1, 2024

[Snyk] Upgrade chai from 4.5.0 to 5.1.1 OKEAMAH/ERCs#9

Open

[Snyk] Upgrade chai from 4.2.0 to 5.1.1 OKEAMAH/genesis-contracts#4

Open

H1B0B0 mentioned this pull request Aug 23, 2024

[Snyk] Upgrade chai from 5.1.0 to 5.1.1 H1B0B0/Kurama-chat#10

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set support in same members #1583

Set support in same members #1583

koddsson commented Jan 26, 2024 •

edited

Loading

43081j commented Jan 27, 2024

keithamus commented Jan 27, 2024

koddsson commented Jan 27, 2024

koddsson commented Jan 27, 2024

keithamus Jan 27, 2024

koddsson commented Jan 28, 2024

koddsson commented Feb 11, 2024

Set support in same members #1583

Set support in same members #1583

Conversation

koddsson commented Jan 26, 2024 • edited Loading

43081j commented Jan 27, 2024

keithamus commented Jan 27, 2024

koddsson commented Jan 27, 2024

koddsson commented Jan 27, 2024

keithamus Jan 27, 2024

Choose a reason for hiding this comment

koddsson commented Jan 28, 2024

koddsson commented Feb 11, 2024

koddsson commented Jan 26, 2024 •

edited

Loading