Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: types and tests #10660

Merged
merged 1 commit into from
Sep 10, 2022
Merged

fix: types and tests #10660

merged 1 commit into from
Sep 10, 2022

Conversation

dangreen
Copy link
Collaborator

@dangreen dangreen commented Sep 8, 2022

  • Fix tsconfig to cover d.ts files
  • Fix types

@dangreen dangreen mentioned this pull request Sep 9, 2022
Merged
@dangreen
Copy link
Collaborator Author

dangreen commented Sep 9, 2022

@LeeLenaleee @etimberg @kurkle Review please 🙏

@etimberg etimberg added the type: types Typescript type changes label Sep 10, 2022
@etimberg etimberg added this to the Version 4.0 milestone Sep 10, 2022
@etimberg etimberg merged commit 83a41c2 into chartjs:master Sep 10, 2022
@dangreen dangreen deleted the fix-ts branch September 11, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

@LeeLenaleee LeeLenaleee LeeLenaleee approved these changes

Assignees
No one assigned
Labels
type: types Typescript type changes
Projects
None yet
Milestone
Version 4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dangreen @etimberg @LeeLenaleee