Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript: NodeNext support #10661

Merged
merged 1 commit into from
Sep 14, 2022
Merged

TypeScript: NodeNext support #10661

merged 1 commit into from
Sep 14, 2022

Conversation

dangreen
Copy link
Collaborator

@dangreen dangreen commented Sep 9, 2022 •
edited
Loading

@dangreen dangreen changed the title Feat ts node next TypeScript: NodeNext support Sep 9, 2022
@dangreen dangreen marked this pull request as ready for review September 11, 2022 09:06
kurkle
kurkle approved these changes Sep 11, 2022
View reviewed changes
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Does the rollup dts plugin do better job emitting definitions?

@dangreen
Copy link
Collaborator Author

@kurkle rollup-plugin-dts bundles typings into one file

Chart.js(feat-ts-node-next)$ tree dist
dist
├── chart.js
├── chart.js.map
├── chart.umd.js
├── chart.umd.js.map
├── chunks
│   ├── helpers.core.d.ts
│   ├── helpers.segment.js
│   └── helpers.segment.js.map
├── helpers.d.ts
├── helpers.js
├── helpers.js.map
└── types.d.ts

@etimberg etimberg merged commit 47cb9e1 into chartjs:master Sep 14, 2022
@etimberg etimberg added this to the Version 4.0 milestone Sep 14, 2022
@dangreen dangreen deleted the feat-ts-node-next branch September 14, 2022 10:50
@LeeLenaleee LeeLenaleee mentioned this pull request Sep 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

@kurkle kurkle kurkle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 4.0
Development

Successfully merging this pull request may close these issues.

Typescript issue with moduleResolution: NodeNext
3 participants
@dangreen @etimberg @kurkle