Develop #2
Merged
Develop #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add fns to take url and create/restore dump * mount a volume to the job for backups * create a pvc if storageclass provided * add storageclass and backup storage size * compare alembic current and head to decide on dump * use pymysql where possible * install mysql client in image * log head and current * Auto-update of E2E template * move database dump and restore into sqlzenstore * rename storage class to backup storage class * make pvc a helm hook resource to be created before job * Auto-update of NLP template * pass backup directory as store config * add check for current and head * add function to check head revisions * Auto-update of Starter template * Auto-update of E2E template * catch exceptions and add connection options * Auto-update of Starter template * implement sqldump in python * more fixes but still doesn't work :(( * fix a host of syntax problems with SQL dumping * add backticks to all column names * remove mysqldump installation * Fix secrets store initialization after merge * move attribute inside the database dict in helm values * Auto-update of Starter template * Auto-update of E2E template * Auto-update of NLP template * Fixes and improvements * removed old DB upgrade code from pre-alembic days * moved DB backup/restore try-catch block closer to where the alembic upgrade happens * better logs in case of failures * use OS file copy instead of sqlite utility to backup SQLite database * avoid unnecessary DB backup and restore operations * Friendlier error message in case of successful DB restore after failed upgrade * Remove test upgrade failure accidentally inserted in previous commit * Fix helm chart * Take db name from config during restore * Create tables at the top of the backup db script and print the first 500 lines in the log in case of errors * Implemented working JSON and DB backup strategies * Restore chart version * Fix helm chart backup volume condition * add pvc deletion policy * add note for setting fsGroup when using PVC * Moved DB backup/restore code to a separate file and add in-memory backup strategy * Fix the format script to use bash instead of sh * Fix docstrings * Update src/zenml/zen_stores/sql_zen_store.py Co-authored-by: Michael Schuster <[email protected]> * Reuse existing backup and doc updates * Apply code review suggestions * Add overwrite and cleanup options to backup/restore CLI commands * Fix docstrings * Fixed removal and reuse of DB backups after failed migration attempts and added more docs * Remove unused attribute --------- Co-authored-by: GitHub Actions <[email protected]> Co-authored-by: Stefan Nica <[email protected]> Co-authored-by: Michael Schuster <[email protected]>
* prepare release * trigger ci * revert fake
bcdurak
pushed a commit
that referenced
this pull request
May 7, 2024
* Added label studio setting * Update * Api key attribute * Added zenml-io#2626 * Docs change * Update src/zenml/integrations/label_studio/annotators/label_studio_annotator.py * mypy fix #1 * mypy fix #2 * mypy fix #3 --------- Co-authored-by: Alex Strick van Linschoten <[email protected]> Co-authored-by: Alex Strick van Linschoten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe changes
I implemented/fixed _ to achieve _.
Pre-requisites
Please ensure you have done the following:
developand the open PR is targetingdevelop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes