Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for fmt10 #58

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update fmt10.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/6438589928, please use this URL for debugging.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@kkraus14
Copy link
Contributor

kkraus14 commented Oct 7, 2023

Okay cool, building the tests caught that things actually fail with these new versions.

[ 19%] Building CUDA object tests/CMakeFiles/THRUST_ALLOCATOR_TEST.dir/mr/device/thrust_allocator_tests.cu.o
cd $SRC_DIR/rmm/build/tests && $BUILD_PREFIX/bin/nvcc -forward-unknown-to-host-compiler -DFMT_HEADER_ONLY=1 -DFMT_SHARED -DSPDLOG_ACTIVE_LEVEL=SPDLOG_LEVEL_INFO -DSPDLOG_FMT_EXTERNAL -DTHRUST_DEVICE_SYSTEM=THRUST_DEVICE_SYSTEM_CUDA -DTHRUST_HOST_SYSTEM=THRUST_HOST_SYSTEM_CPP --options-file CMakeFiles/THRUST_ALLOCATOR_TEST.dir/includes_CUDA.rsp -O3 -DNDEBUG "--generate-code=arch=compute_60,code=[sm_60]" "--generate-code=arch=compute_70,code=[sm_70]" "--generate-code=arch=compute_75,code=[sm_75]" "--generate-code=arch=compute_80,code=[sm_80]" "--generate-code=arch=compute_86,code=[sm_86]" "--generate-code=arch=compute_90,code=[compute_90,sm_90]" -Xcompiler=-fPIE -MD -MT tests/CMakeFiles/THRUST_ALLOCATOR_TEST.dir/mr/device/thrust_allocator_tests.cu.o -MF CMakeFiles/THRUST_ALLOCATOR_TEST.dir/mr/device/thrust_allocator_tests.cu.o.d -x cu -c $SRC_DIR/rmm/tests/mr/device/thrust_allocator_tests.cu -o CMakeFiles/THRUST_ALLOCATOR_TEST.dir/mr/device/thrust_allocator_tests.cu.o
/home/conda/feedstock_root/build_artifacts/librmm_1696649221989/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_plac/include/spdlog/common.h: In function 'constexpr spdlog::string_view_t spdlog::details::to_string_view(const memory_buf_t&)':
/home/conda/feedstock_root/build_artifacts/librmm_1696649221989/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_plac/include/spdlog/common.h:351:30: error: call to non-'constexpr' function 'const T* fmt::v10::detail::buffer<T>::data() const [with T = char]'
  351 |     return spdlog::string_view_t{buf.data(), buf.size()};
      |                      ~~~~~~~~^~
/home/conda/feedstock_root/build_artifacts/librmm_1696649221989/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_plac/include/fmt/core.h:845:6: note: 'const T* fmt::v10::detail::buffer<T>::data() const [with T = char]' declared here
  845 |   FMT_CONSTEXPR auto data() const noexcept -> const T* { return ptr_; }
      |      ^~~~
gmake[2]: *** [tests/CMakeFiles/THRUST_ALLOCATOR_TEST.dir/mr/device/thrust_allocator_tests.cu.o] Error 1

I'm not seeing any RMM code here where it looks similar to gabime/spdlog#2142

EDIT: This seems to be the issue: gabime/spdlog#2856

This is unrelated to RMM and is a general spdlog + nvcc issue that impacts building some RMM tests that have device code.

@jakirkham
Copy link
Member

Is it alright if we ask the bot to rerun this one?

@kkraus14
Copy link
Contributor

Is it alright if we ask the bot to rerun this one?

Sure, but there's a bug upstream in spdlog that will prevent things from succeeding.

@jakirkham jakirkham marked this pull request as draft October 11, 2023 18:35
@jakirkham
Copy link
Member

Ah ok. Let's mark as draft then. Can follow up whenever the upstream issue is addressed

@kkraus14
Copy link
Contributor

@conda-forge-admin, please rerender

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/librmm-feedstock/actions/runs/6528342374.

@kkraus14 kkraus14 marked this pull request as ready for review October 16, 2023 03:09
@kkraus14
Copy link
Contributor

@jakirkham this should be ready to review now. Got a PR merged upstream fixing spdlog and a patch backporting it to v1.12 into the spdlog feedstock.

@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/librmm-feedstock/actions/runs/6538352299.

@jakirkham
Copy link
Member

@conda-forge-admin , please re-render

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/librmm-feedstock/actions/runs/6538521392.

@jakirkham jakirkham added the automerge Merge the PR when CI passes label Oct 16, 2023
@github-actions github-actions bot merged commit 7892bc9 into conda-forge:main Oct 16, 2023
11 checks passed
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@jakirkham
Copy link
Member

Thanks Keith! 🙏

@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-fmt10-0-1_h8cce97 branch October 16, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants