Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Update to spdlog 1.12 and fmt 10 #1356

Closed
kkraus14 opened this issue Oct 7, 2023 · 3 comments · Fixed by #1374
Closed

[FEA] Update to spdlog 1.12 and fmt 10 #1356

kkraus14 opened this issue Oct 7, 2023 · 3 comments · Fixed by #1374
Labels
? - Needs Triage Need team to review and classify feature request New feature or request

Comments

@kkraus14
Copy link
Contributor

kkraus14 commented Oct 7, 2023

Conda-forge has an ongoing migration in moving the pinning to spdlog 1.12 and fmt 10: https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/main/recipe/migrations/fmt10.yaml

An attempt was made to build the RMM 23.08 tests with those versions here conda-forge/librmm-feedstock#58, but it fails due to a compilation issue (that doesn't look to have RMM code in the trace 🙃).

As the migrator continues to run, other packages will only be built with spdlog 1.12 / fmt 10 where it will cause problems in solving environments if there isn't builds of RMM (and other RAPIDS packages) with spdlog 1.12 + fmt 10.
@kkraus14 kkraus14 added ? - Needs Triage Need team to review and classify feature request New feature or request labels Oct 7, 2023
@kkraus14
Copy link
Contributor Author

kkraus14 commented Oct 8, 2023

Issue seems to be this: gabime/spdlog#2856

@harrism
Copy link
Member

harrism commented Oct 8, 2023

Thanks for alerting us to this @kkraus14 . Looks like we need to wait for a fix in spdlog and then adopt the fixed version.

@kkraus14
Copy link
Contributor Author

Got the fix merged upstream in spdlog in gabime/spdlog#2901.

Will backport that to a patch for the conda-forge 1.12 build as well as a patch for rapids-cmake to unblock this.

@kkraus14 kkraus14 mentioned this issue Oct 16, 2023
Merged
7 tasks
@bdice bdice mentioned this issue Nov 30, 2023
Merged
rapids-bot bot pushed a commit that referenced this issue Nov 30, 2023
@bdice
Update to fmt 10.1.1 and spdlog 1.12.0. (#1374)
d8579b7 
This PR updates to fmt 10.1.1 and spdlog 1.12.

Depends on rapidsai/rapids-cmake#473.

Closes #1356

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Jake Awe (https://github.com/AyodeAwe)

URL: #1374
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
? - Needs Triage Need team to review and classify feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to fmt 10.1.1 and spdlog 1.12.0. bdice/rmm
2 participants
@harrism @kkraus14