Refactor JS code #732
Merged
Refactor JS code #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yusiro-bps
force-pushed
the
feature/js_refactoring
branch
2 times, most recently
from
03ccfda
to
c44af89
Compare
yohm
reviewed
Feb 24, 2021
app/assets/javascripts/files.js
Outdated
| }, | ||
| pageLength: 100 | ||
| }); | ||
| $(() => { |
There was a problem hiding this comment.
こちらは $( ()=>{... } ) としていますが、他と同様に即時実行関数 ( ()=>{...} )() として書いていないのは何か意図があるのでしょうか？
There was a problem hiding this comment.
ご指摘ありがとうございます。私が書き違えていました。ここも他と同様に関数呼び出しのタイミングによって未定義エラーにならないように即時実行関数を使うことを意図していますので修正します。
yusiro-bps
force-pushed
the
feature/js_refactoring
branch
from
6cdd4c4
to
3c75fd0
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #711
対応内容