Add finished and unfinished Runs tabs in simulators#:id #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yohm Finished / Unfinished Runsが表示されるようにしてみました。スクリーンショットはPR descriptionの通りです。 一点、Analysesも表示した方が良さそうな気がしたので、そちらの対応も必要か、確認お願いいたします 🙇♂️ |
morimorihoge
commented
Feb 19, 2021
| render json: RunsListDatatable.new(Run.in(status: stat), view_context) | ||
| conditions = {} | ||
| conditions[:status] = params["run_status"] # required | ||
| conditions[:simulator_id] = params["simulator_id"] if params["simulator_id"].present? |
There was a problem hiding this comment.
optionalな引数として simulator_id を渡せるように更新しています
morimorihoge
commented
Feb 19, 2021
| $(function() { | ||
| // finished runs | ||
| const oFinishedRunsTable = datatables_for_runs_table('#finished_runs_list'); | ||
| }); |
There was a problem hiding this comment.
この辺のloadingコードはshowの方にまとめても良かったのですが、参照しているElement idが同じファイル内に見えていた方が可読性としては良いかなと思い、それぞれのpartial側で呼び出すようにしています。
|
定例にて、Analysesは表示不要とのこと（Progressも同様なので、それに従う）を確認頂いたので、テストコードを増やした上でDraftを外す方向で対応させて頂きます。 |
morimorihoge
force-pushed
the
feature/add-run-tables-in-simulator
branch
from
28f466a
to
61d7f8a
Compare
|
@yohm こちら、テストコードの方追加いたしましたのでmerge readyになります。 |
yohm
requested changes
Feb 26, 2021
yohm
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simulators#showページに
Finished Runs及びUnfinished Runsを追加 refs #717要確認