-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed bug in #169 #181
Fixed bug in #169 #181
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #181 +/- ##
===========================================
+ Coverage 73.21% 87.75% +14.53%
===========================================
Files 7 6 -1
Lines 2035 1707 -328
===========================================
+ Hits 1490 1498 +8
+ Misses 545 209 -336 ☔ View full report in Codecov by Sentry. |
This comment was marked as outdated.
This comment was marked as outdated.
This PR reinstates the |
In theory yes 👍 |
This PR will need to be tested to see if its still functional and dosn't generate any bugs. |
Ok, we will probably integrate this in a future 0.9.0 release along with the new MLRegression class. Also requirements_addon.txt file is no longer needed right? |
Oh sorry. Yeah I don't believe so. |
It may be good to keep the web server requirements if you want to specify the version of flask, waitress and ploty. I'll change the Docker to use the file if that's the case? @davidusb-geek |
Yes we will keep the web server requirements and erase the other requirements_addon file |
Making a PR now. |
Related to, and possible fix for issue: davidusb-geek/emhass-add-on#74