feat: change way to generate NavbarPagesUrl

decentraland · Jul 15, 2024 · 832907f · 832907f
1 parent e9b05ef
commit 832907f
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 20 deletions.
diff --git a/src/components/Navbar/MainMenu/MainMenu.tsx b/src/components/Navbar/MainMenu/MainMenu.tsx
@@ -4,13 +4,15 @@ import classNames from 'classnames'
 import { MenuItem } from '../MenuItem/MenuItem'
 import { NavbarPages } from '../Navbar.types'
 import { MainMenuProps } from './MainMenu.types'
-import { NavbarPagesUrl } from '../utils'
+import { getNavbarPagesUrls } from '../utils'
 
 import './MainMenu.css'
 
 export const MainMenu = (props: MainMenuProps) => {
   const { i18n, ...menuItemProps } = props
 
+  const urls = getNavbarPagesUrls()
+
   return (
     <div
       className={classNames(
@@ -23,31 +25,31 @@ export const MainMenu = (props: MainMenuProps) => {
         {...menuItemProps}
         section={NavbarPages.MARKETPLACE}
         title={i18n.marketplace}
-        mainUrl={NavbarPagesUrl(NavbarPages.MARKETPLACE)}
+        mainUrl={urls[NavbarPages.MARKETPLACE]}
       />
       <MenuItem
         {...menuItemProps}
         section={NavbarPages.CREATE}
         title={i18n.create}
-        mainUrl={NavbarPagesUrl(NavbarPages.CREATE)}
+        mainUrl={urls[NavbarPages.CREATE]}
       />
       <MenuItem
         {...menuItemProps}
         section={NavbarPages.EXPLORE}
         title={i18n.explore}
-        mainUrl={NavbarPagesUrl(NavbarPages.EXPLORE)}
+        mainUrl={urls[NavbarPages.EXPLORE]}
       />
       <MenuItem
         {...menuItemProps}
         section={NavbarPages.LEARN}
         title={i18n.learn}
-        mainUrl={NavbarPagesUrl(NavbarPages.LEARN)}
+        mainUrl={urls[NavbarPages.LEARN]}
       />
       <MenuItem
         {...menuItemProps}
         section={NavbarPages.GOVERNANCE}
         title={i18n.governance}
-        mainUrl={NavbarPagesUrl(NavbarPages.GOVERNANCE)}
+        mainUrl={urls[NavbarPages.GOVERNANCE]}
       />
     </div>
   )

diff --git a/src/components/Navbar/utils.ts b/src/components/Navbar/utils.ts
@@ -1,19 +1,12 @@
 import { config } from '../../config'
 import { NavbarPages } from './Navbar.types'
 
-export const NavbarPagesUrl = (navPage: NavbarPages) => {
-  switch (navPage) {
-    case NavbarPages.MARKETPLACE:
-      return config.get('MARKETPLACE_URL')
-    case NavbarPages.CREATE:
-      return config.get('LANDING_CREATORS_URL')
-    case NavbarPages.EXPLORE:
-      return config.get('EVENTS_URL')
-    case NavbarPages.LEARN:
-      return config.get('DOCS_ABOUT_URL')
-    case NavbarPages.GOVERNANCE:
-      return config.get('GOVERNANCE_URL')
-    default:
-      return ''
+export const getNavbarPagesUrls = () => {
+  return {
+    [NavbarPages.MARKETPLACE]: config.get('MARKETPLACE_URL'),
+    [NavbarPages.CREATE]: config.get('LANDING_CREATORS_URL'),
+    [NavbarPages.EXPLORE]: config.get('EVENTS_URL'),
+    [NavbarPages.LEARN]: config.get('DOCS_ABOUT_URL'),
+    [NavbarPages.GOVERNANCE]: config.get('GOVERNANCE_URL')
   }
 }