Implement rollup protocol #2275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgrigis
requested changes
May 15, 2020
| if err != nil { | ||
| return nil, xerrors.Errorf("Error starting the protocol", err) | ||
| } | ||
| if err := <-root.DoneChan; err != nil { |
There was a problem hiding this comment.
Perhaps it would be safer to select with a timeout, to avoid waiting forever
There was a problem hiding this comment.
This was changed
byzcoin/service.go
Outdated
| ch := s.notifications.registerForBlocks() | ||
| defer s.notifications.unregisterForBlocks(ch) | ||
|
|
||
| //TODO : create new block if txBuffer is not empty directly after creating another one |
cgrigis
reviewed
May 15, 2020
cgrigis
reviewed
May 15, 2020
cgrigis
reviewed
May 15, 2020
Fix AddTransactionVersion
Rollup more tests
waiting some more
louismerlin
commented
May 19, 2020
|
Closed in favour of #2321 |
|
Sorry about that ! We've lacked the motivation to finish the PR now that we're both at 100% employment... We hope the new one will get through :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
See commit message
This PR implements the rollup protocol to replace the collect protocol, in the context of our master semester project.
🙅 Friendly checklist:
xerrors.Errorfand the%vverb.