-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement rollup protocol #2275
Conversation
if err != nil { | ||
return nil, xerrors.Errorf("Error starting the protocol", err) | ||
} | ||
if err := <-root.DoneChan; err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps it would be safer to select
with a timeout, to avoid waiting forever
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was changed
byzcoin/service.go
Outdated
ch := s.notifications.registerForBlocks() | ||
defer s.notifications.unregisterForBlocks(ch) | ||
|
||
//TODO : create new block if txBuffer is not empty directly after creating another one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do :)
Fix AddTransactionVersion
Rollup more tests
waiting some more
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like it wasn't enough...
Closed in favour of #2321 |
Sorry about that ! We've lacked the motivation to finish the PR now that we're both at 100% employment... We hope the new one will get through :) |
What this PR does
See commit message
This PR implements the rollup protocol to replace the collect protocol, in the context of our master semester project.
🙅 Friendly checklist:
xerrors.Errorf
and the%v
verb.