Rollup protocol #2321
Merged
Rollup protocol #2321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ineiti
force-pushed
the
rollup-protocol
branch
7 times, most recently
from
17174af
to
8b5050f
Compare
16 tasks
ineiti
force-pushed
the
rollup-protocol
branch
11 times, most recently
from
170630c
to
f901058
Compare
tharvik
reviewed
Jul 29, 2020
Previously the leader polled for new transactions. This is inefficient, as new transactions have to wait for the leader to poll. With this PR, the all followers forward transactions directly to the leader. Once the leader has a transaction, he directly starts a new block. Once the new block has been accepted, eventually queued up transactions are also sent. This has been tested to be able to go from old nodes to new nodes on a local machine.
|
Thanks, I think I addressed all of the comments. Now I'm tempted to try and switch the chain tomorrow - just before 2 weeks of holidays... Probably not a good idea ;) |
tharvik
approved these changes
Jul 29, 2020
|
OK - let's be crazy. I'll merge it and launch an update of the nodes tomorrow morning (4am UTC). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the transaction-gathering loop by a 'create-blocks-as-transactions-arrive'.
Instead of querying every
blockIntervalseconds all nodes for new transactions, this PR has all nodes sending their transactions to the leader whenever they get one.The leader will immediately start a new block with the first transaction. While the block is created, more transactions can queue up. Once the block is done, all queued transactions will be put in a new block.
heartbeat,collect_tx, and others, which are not necessarily interesting...PLEASE DO NOT MERGE YET!