Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adr for caching implementation #707

Merged
merged 5 commits into from
Jun 18, 2024
Merged

chore: adr for caching implementation #707

merged 5 commits into from
Jun 18, 2024

Conversation

decleaver
Copy link
Collaborator

Description

ADR

Related Issue

Relates to #653

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@decleaver decleaver changed the title chore: ADR for caching implementation chore: adr for caching implementation Jun 17, 2024
adr/0007-caching.md Outdated Show resolved Hide resolved
adr/0007-caching.md Outdated Show resolved Hide resolved
adr/0007-caching.md Outdated Show resolved Hide resolved
@UncleGedd
Copy link
Collaborator

UncleGedd commented Jun 17, 2024

Awesome! Couple of suggestions:

  • Add some context for the current state of our caching (ie. how we're using both options right now)
  • Describe the chosen solution in more detail; discuss the .uds-cache dir and what layers we will/won't cache and why

UncleGedd
UncleGedd previously approved these changes Jun 18, 2024
TristanHoladay
TristanHoladay previously approved these changes Jun 18, 2024
@decleaver decleaver dismissed stale reviews from TristanHoladay and UncleGedd via 8448d74 June 18, 2024 14:34
@decleaver decleaver merged commit 4492915 into main Jun 18, 2024
3 checks passed
@decleaver decleaver deleted the 653-caching-refactor branch June 18, 2024 14:40
jeff-mccoy pushed a commit that referenced this pull request Jun 28, 2024
mjnagel pushed a commit to defenseunicorns/uds-core that referenced this pull request Jul 2, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[defenseunicorns/uds-cli](https://github.com/defenseunicorns/uds-cli)
| minor | `0.11.2` -> `0.12.0` |
|
[defenseunicorns/uds-cli](https://github.com/defenseunicorns/uds-cli)
| minor | `v0.11.2` -> `v0.12.0` |

---

### Release Notes

<details>
<summary>defenseunicorns/uds-cli (defenseunicorns/uds-cli)</summary>

###
[`v0.12.0`](https://github.com/defenseunicorns/uds-cli/releases/tag/v0.12.0)

[Compare
Source](https://github.com/defenseunicorns/uds-cli/compare/v0.11.2...v0.12.0)

#### What's Changed

- feat: uds monitor pepr by
[@&#8203;jeff-mccoy](https://github.com/jeff-mccoy) in
[defenseunicorns/uds-cli#696
- docs: remove out of place quotation by
[@&#8203;zachariahmiller](https://github.com/zachariahmiller) in
[defenseunicorns/uds-cli#706
- chore: ensure nginx shorthand in dev tests by
[@&#8203;UncleGedd](https://github.com/UncleGedd) in
[defenseunicorns/uds-cli#700
- chore(deps): update actions/checkout action to v4.1.7 by
[@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#697
- chore(deps): update homebrew/actions digest to
[`1be15ef`](https://github.com/defenseunicorns/uds-cli/commit/1be15ef)
by [@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#683
- fix(deps): update module github.com/fatih/color to v1.17.0 by
[@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#678
- fix(deps): update golang.org/x/exp digest to
[`7f521ea`](https://github.com/defenseunicorns/uds-cli/commit/7f521ea)
by [@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#642
- chore(deps): update github/codeql-action action to v3.25.10 by
[@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#649
- fix(deps): update module helm.sh/helm/v3 to v3.15.2 by
[@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#690
- chore: adr for caching implementation by
[@&#8203;decleaver](https://github.com/decleaver) in
[defenseunicorns/uds-cli#707
- chore: add monitor docs and tests by
[@&#8203;UncleGedd](https://github.com/UncleGedd) in
[defenseunicorns/uds-cli#715
- chore(deps): update zarf to v0.35.0 by
[@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#711
- fix(engine): use k8s timestamps instead of pepr timestamps by
[@&#8203;jeff-mccoy](https://github.com/jeff-mccoy) in
[defenseunicorns/uds-cli#717
- chore(deps): update homebrew/actions digest to
[`68fa6ae`](https://github.com/defenseunicorns/uds-cli/commit/68fa6ae)
by [@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#713
- fix(deps): update module github.com/spf13/cobra to v1.8.1 by
[@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#710
- chore: uds engine install adr by
[@&#8203;decleaver](https://github.com/decleaver) in
[defenseunicorns/uds-cli#699
- fix: update bundle-anatomy.md by
[@&#8203;Madeline-UX](https://github.com/Madeline-UX) in
[defenseunicorns/uds-cli#720
- chore: various doc linting fixes by
[@&#8203;UnicornChance](https://github.com/UnicornChance) in
[defenseunicorns/uds-cli#724
- feat: fall back to non-strict unmarshalling by
[@&#8203;decleaver](https://github.com/decleaver) in
[defenseunicorns/uds-cli#721
- chore(deps): update podinfo to v6.7.0 by
[@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#723
- feat: distinguish between stdout and stderr output by
[@&#8203;UncleGedd](https://github.com/UncleGedd) in
[defenseunicorns/uds-cli#730
- fix(deps): update kubernetes packages to v0.30.2 by
[@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#702
- chore(deps): update actions/create-github-app-token action to v1.10.2
by [@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#727
- feat(ci): included dependency review action by
[@&#8203;naveensrinivasan](https://github.com/naveensrinivasan) in
[defenseunicorns/uds-cli#479
- chore(deps): update actions/dependency-review-action action to v4.3.3
by [@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#732
- chore(deps): update actions/checkout action to v4.1.7 by
[@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#731
- fix: ensure inspected image list is machine readable by
[@&#8203;UncleGedd](https://github.com/UncleGedd) in
[defenseunicorns/uds-cli#734
- fix: release pipeline by
[@&#8203;UncleGedd](https://github.com/UncleGedd) in
[defenseunicorns/uds-cli#739
- fix: release pipeline again by
[@&#8203;UncleGedd](https://github.com/UncleGedd) in
[defenseunicorns/uds-cli#740

#### New Contributors

- [@&#8203;Madeline-UX](https://github.com/Madeline-UX) made their
first contribution in
[defenseunicorns/uds-cli#720

**Full Changelog**:
defenseunicorns/uds-cli@v0.11.2...v0.12.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/defenseunicorns/uds-core).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
rjferguson21 pushed a commit to defenseunicorns/uds-core that referenced this pull request Jul 11, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[defenseunicorns/uds-cli](https://github.com/defenseunicorns/uds-cli)
| minor | `0.11.2` -> `0.12.0` |
|
[defenseunicorns/uds-cli](https://github.com/defenseunicorns/uds-cli)
| minor | `v0.11.2` -> `v0.12.0` |

---

### Release Notes

<details>
<summary>defenseunicorns/uds-cli (defenseunicorns/uds-cli)</summary>

###
[`v0.12.0`](https://github.com/defenseunicorns/uds-cli/releases/tag/v0.12.0)

[Compare
Source](https://github.com/defenseunicorns/uds-cli/compare/v0.11.2...v0.12.0)

#### What's Changed

- feat: uds monitor pepr by
[@&#8203;jeff-mccoy](https://github.com/jeff-mccoy) in
[defenseunicorns/uds-cli#696
- docs: remove out of place quotation by
[@&#8203;zachariahmiller](https://github.com/zachariahmiller) in
[defenseunicorns/uds-cli#706
- chore: ensure nginx shorthand in dev tests by
[@&#8203;UncleGedd](https://github.com/UncleGedd) in
[defenseunicorns/uds-cli#700
- chore(deps): update actions/checkout action to v4.1.7 by
[@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#697
- chore(deps): update homebrew/actions digest to
[`1be15ef`](https://github.com/defenseunicorns/uds-cli/commit/1be15ef)
by [@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#683
- fix(deps): update module github.com/fatih/color to v1.17.0 by
[@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#678
- fix(deps): update golang.org/x/exp digest to
[`7f521ea`](https://github.com/defenseunicorns/uds-cli/commit/7f521ea)
by [@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#642
- chore(deps): update github/codeql-action action to v3.25.10 by
[@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#649
- fix(deps): update module helm.sh/helm/v3 to v3.15.2 by
[@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#690
- chore: adr for caching implementation by
[@&#8203;decleaver](https://github.com/decleaver) in
[defenseunicorns/uds-cli#707
- chore: add monitor docs and tests by
[@&#8203;UncleGedd](https://github.com/UncleGedd) in
[defenseunicorns/uds-cli#715
- chore(deps): update zarf to v0.35.0 by
[@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#711
- fix(engine): use k8s timestamps instead of pepr timestamps by
[@&#8203;jeff-mccoy](https://github.com/jeff-mccoy) in
[defenseunicorns/uds-cli#717
- chore(deps): update homebrew/actions digest to
[`68fa6ae`](https://github.com/defenseunicorns/uds-cli/commit/68fa6ae)
by [@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#713
- fix(deps): update module github.com/spf13/cobra to v1.8.1 by
[@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#710
- chore: uds engine install adr by
[@&#8203;decleaver](https://github.com/decleaver) in
[defenseunicorns/uds-cli#699
- fix: update bundle-anatomy.md by
[@&#8203;Madeline-UX](https://github.com/Madeline-UX) in
[defenseunicorns/uds-cli#720
- chore: various doc linting fixes by
[@&#8203;UnicornChance](https://github.com/UnicornChance) in
[defenseunicorns/uds-cli#724
- feat: fall back to non-strict unmarshalling by
[@&#8203;decleaver](https://github.com/decleaver) in
[defenseunicorns/uds-cli#721
- chore(deps): update podinfo to v6.7.0 by
[@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#723
- feat: distinguish between stdout and stderr output by
[@&#8203;UncleGedd](https://github.com/UncleGedd) in
[defenseunicorns/uds-cli#730
- fix(deps): update kubernetes packages to v0.30.2 by
[@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#702
- chore(deps): update actions/create-github-app-token action to v1.10.2
by [@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#727
- feat(ci): included dependency review action by
[@&#8203;naveensrinivasan](https://github.com/naveensrinivasan) in
[defenseunicorns/uds-cli#479
- chore(deps): update actions/dependency-review-action action to v4.3.3
by [@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#732
- chore(deps): update actions/checkout action to v4.1.7 by
[@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#731
- fix: ensure inspected image list is machine readable by
[@&#8203;UncleGedd](https://github.com/UncleGedd) in
[defenseunicorns/uds-cli#734
- fix: release pipeline by
[@&#8203;UncleGedd](https://github.com/UncleGedd) in
[defenseunicorns/uds-cli#739
- fix: release pipeline again by
[@&#8203;UncleGedd](https://github.com/UncleGedd) in
[defenseunicorns/uds-cli#740

#### New Contributors

- [@&#8203;Madeline-UX](https://github.com/Madeline-UX) made their
first contribution in
[defenseunicorns/uds-cli#720

**Full Changelog**:
defenseunicorns/uds-cli@v0.11.2...v0.12.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/defenseunicorns/uds-core).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants