fix(engine): use k8s timestamps instead of pepr timestamps #717

jeff-mccoy · 2024-06-19T21:54:38Z

Description

This PR uses the native K8s timestamp feature (which is the CRI Log format instead of the timestamp from the pod. This ensure behavior consistent with normal K8s log output, reduces the need to parse each timestamp and eleminates an issue that exists for timestamp parsing currently.

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Other (security config, docs update, etc)

src/pkg/engine/pepr/stream.go

Co-authored-by: UncleGedd <[email protected]>

UncleGedd

🚀 appreciate the context lifting and improved timestamp handling

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [defenseunicorns/uds-cli](https://github.com/defenseunicorns/uds-cli) | minor | `0.11.2` -> `0.12.0` | | [defenseunicorns/uds-cli](https://github.com/defenseunicorns/uds-cli) | minor | `v0.11.2` -> `v0.12.0` | --- ### Release Notes <details> <summary>defenseunicorns/uds-cli (defenseunicorns/uds-cli)</summary> ### [`v0.12.0`](https://github.com/defenseunicorns/uds-cli/releases/tag/v0.12.0) [Compare Source](https://github.com/defenseunicorns/uds-cli/compare/v0.11.2...v0.12.0) #### What's Changed - feat: uds monitor pepr by [@jeff-mccoy](https://github.com/jeff-mccoy) in [defenseunicorns/uds-cli#696 - docs: remove out of place quotation by [@zachariahmiller](https://github.com/zachariahmiller) in [defenseunicorns/uds-cli#706 - chore: ensure nginx shorthand in dev tests by [@UncleGedd](https://github.com/UncleGedd) in [defenseunicorns/uds-cli#700 - chore(deps): update actions/checkout action to v4.1.7 by [@renovate](https://github.com/renovate) in [defenseunicorns/uds-cli#697 - chore(deps): update homebrew/actions digest to [`1be15ef`](https://github.com/defenseunicorns/uds-cli/commit/1be15ef) by [@renovate](https://github.com/renovate) in [defenseunicorns/uds-cli#683 - fix(deps): update module github.com/fatih/color to v1.17.0 by [@renovate](https://github.com/renovate) in [defenseunicorns/uds-cli#678 - fix(deps): update golang.org/x/exp digest to [`7f521ea`](https://github.com/defenseunicorns/uds-cli/commit/7f521ea) by [@renovate](https://github.com/renovate) in [defenseunicorns/uds-cli#642 - chore(deps): update github/codeql-action action to v3.25.10 by [@renovate](https://github.com/renovate) in [defenseunicorns/uds-cli#649 - fix(deps): update module helm.sh/helm/v3 to v3.15.2 by [@renovate](https://github.com/renovate) in [defenseunicorns/uds-cli#690 - chore: adr for caching implementation by [@decleaver](https://github.com/decleaver) in [defenseunicorns/uds-cli#707 - chore: add monitor docs and tests by [@UncleGedd](https://github.com/UncleGedd) in [defenseunicorns/uds-cli#715 - chore(deps): update zarf to v0.35.0 by [@renovate](https://github.com/renovate) in [defenseunicorns/uds-cli#711 - fix(engine): use k8s timestamps instead of pepr timestamps by [@jeff-mccoy](https://github.com/jeff-mccoy) in [defenseunicorns/uds-cli#717 - chore(deps): update homebrew/actions digest to [`68fa6ae`](https://github.com/defenseunicorns/uds-cli/commit/68fa6ae) by [@renovate](https://github.com/renovate) in [defenseunicorns/uds-cli#713 - fix(deps): update module github.com/spf13/cobra to v1.8.1 by [@renovate](https://github.com/renovate) in [defenseunicorns/uds-cli#710 - chore: uds engine install adr by [@decleaver](https://github.com/decleaver) in [defenseunicorns/uds-cli#699 - fix: update bundle-anatomy.md by [@Madeline-UX](https://github.com/Madeline-UX) in [defenseunicorns/uds-cli#720 - chore: various doc linting fixes by [@UnicornChance](https://github.com/UnicornChance) in [defenseunicorns/uds-cli#724 - feat: fall back to non-strict unmarshalling by [@decleaver](https://github.com/decleaver) in [defenseunicorns/uds-cli#721 - chore(deps): update podinfo to v6.7.0 by [@renovate](https://github.com/renovate) in [defenseunicorns/uds-cli#723 - feat: distinguish between stdout and stderr output by [@UncleGedd](https://github.com/UncleGedd) in [defenseunicorns/uds-cli#730 - fix(deps): update kubernetes packages to v0.30.2 by [@renovate](https://github.com/renovate) in [defenseunicorns/uds-cli#702 - chore(deps): update actions/create-github-app-token action to v1.10.2 by [@renovate](https://github.com/renovate) in [defenseunicorns/uds-cli#727 - feat(ci): included dependency review action by [@naveensrinivasan](https://github.com/naveensrinivasan) in [defenseunicorns/uds-cli#479 - chore(deps): update actions/dependency-review-action action to v4.3.3 by [@renovate](https://github.com/renovate) in [defenseunicorns/uds-cli#732 - chore(deps): update actions/checkout action to v4.1.7 by [@renovate](https://github.com/renovate) in [defenseunicorns/uds-cli#731 - fix: ensure inspected image list is machine readable by [@UncleGedd](https://github.com/UncleGedd) in [defenseunicorns/uds-cli#734 - fix: release pipeline by [@UncleGedd](https://github.com/UncleGedd) in [defenseunicorns/uds-cli#739 - fix: release pipeline again by [@UncleGedd](https://github.com/UncleGedd) in [defenseunicorns/uds-cli#740 #### New Contributors - [@Madeline-UX](https://github.com/Madeline-UX) made their first contribution in [defenseunicorns/uds-cli#720 **Full Changelog**: defenseunicorns/uds-cli@v0.11.2...v0.12.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/defenseunicorns/uds-core).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

move ctx to the actual stream / use k8s timestamps

a9daff4

jeff-mccoy changed the title ~~fix (engine): use k8s timestamps instead of pepr timestamps~~ fix(engine): use k8s timestamps instead of pepr timestamps Jun 19, 2024

jeff-mccoy marked this pull request as ready for review June 20, 2024 05:08

jeff-mccoy requested review from UncleGedd, decleaver, mjnagel and TristanHoladay as code owners June 20, 2024 05:08

UncleGedd reviewed Jun 20, 2024

View reviewed changes

src/pkg/engine/pepr/stream.go Outdated Show resolved Hide resolved

Update src/pkg/engine/pepr/stream.go

413df3c

Co-authored-by: UncleGedd <[email protected]>

UncleGedd self-requested a review June 20, 2024 13:58

UncleGedd approved these changes Jun 20, 2024

View reviewed changes

UncleGedd merged commit bbedaaa into main Jun 20, 2024
17 checks passed

UncleGedd deleted the engine-fix-timestamp branch June 20, 2024 14:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(engine): use k8s timestamps instead of pepr timestamps #717

fix(engine): use k8s timestamps instead of pepr timestamps #717

jeff-mccoy commented Jun 19, 2024 •

edited

Loading

UncleGedd left a comment

fix(engine): use k8s timestamps instead of pepr timestamps #717

fix(engine): use k8s timestamps instead of pepr timestamps #717

Conversation

jeff-mccoy commented Jun 19, 2024 • edited Loading

Description

Type of change

UncleGedd left a comment

Choose a reason for hiding this comment

jeff-mccoy commented Jun 19, 2024 •

edited

Loading