Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ensure stdout for inspect [FLAGS] #759

Merged
merged 19 commits into from
Jul 11, 2024
Merged

chore: ensure stdout for inspect [FLAGS] #759

merged 19 commits into from
Jul 11, 2024

Conversation

TristanHoladay
Copy link
Collaborator

Description

Make sure all output of uds inspect [FLAGS] directs to stdout so easily grabbed for other uses.

Related Issue

Resolves #738

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

src/pkg/bundle/inspect.go Outdated Show resolved Hide resolved
@UncleGedd
Copy link
Collaborator

Will take a look at this tonight!

@UncleGedd
Copy link
Collaborator

If I a uds inspect k3d-core-slim-dev:latest > tmp and cat tmp then the tmp file has the colors in it which makes it hard for automation to read it. Can you add a global --no-color flag to provide the option to print in plain text

@UncleGedd
Copy link
Collaborator

If I a uds inspect k3d-core-slim-dev:latest > tmp and cat tmp then the tmp file has the colors in it which makes it hard for automation to read it. Can you add a global --no-color flag to provide the option to print in plain text

Feel free to make this a follow-up issue if you'd like, your call!

@TristanHoladay
Copy link
Collaborator Author

@UncleGedd should --no-color apply only to what goes to stdout like inspect?

@UncleGedd
Copy link
Collaborator

@UncleGedd should --no-color apply only to what goes to stdout like inspect?

Let's go ahead and make it a global option like in Zarf

Copy link
Collaborator

@decleaver decleaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@UncleGedd UncleGedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@UncleGedd UncleGedd merged commit 3186adf into main Jul 11, 2024
15 checks passed
@UncleGedd UncleGedd deleted the chore-stdout branch July 11, 2024 20:01
mjnagel added a commit to defenseunicorns/uds-core that referenced this pull request Jul 24, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[defenseunicorns/uds-cli](https://github.com/defenseunicorns/uds-cli)
| minor | `0.12.0` -> `0.13.1` |
|
[defenseunicorns/uds-cli](https://github.com/defenseunicorns/uds-cli)
| minor | `v0.12.0` -> `v0.13.1` |

---

### Release Notes

<details>
<summary>defenseunicorns/uds-cli (defenseunicorns/uds-cli)</summary>

###
[`v0.13.1`](https://github.com/defenseunicorns/uds-cli/releases/tag/v0.13.1)

[Compare
Source](https://github.com/defenseunicorns/uds-cli/compare/v0.13.0...v0.13.1)

#### What's Changed

- fix: nightly release typo and add checksums by
[@&#8203;UncleGedd](https://github.com/UncleGedd) in
[defenseunicorns/uds-cli#828
- fix: split override envs properly by
[@&#8203;mjnagel](https://github.com/mjnagel) in
[defenseunicorns/uds-cli#829

**Full Changelog**:
defenseunicorns/uds-cli@nightly-unstable...v0.13.1

###
[`v0.13.0`](https://github.com/defenseunicorns/uds-cli/releases/tag/v0.13.0)

[Compare
Source](https://github.com/defenseunicorns/uds-cli/compare/v0.12.0...v0.13.0)

##### What's Changed

- chore(deps): update github/codeql-action action to v3.25.11 by
[@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#744
- chore(deps): update actions/create-github-app-token action to v1.10.3
by [@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#747
- chore(deps): update module github.com/prometheus/common to v0.55.0 by
[@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#666
- chore(deps): update homebrew/actions digest to
[`c9f08ac`](https://github.com/defenseunicorns/uds-cli/commit/c9f08ac)
by [@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#746
- fix(deps): update module github.com/charmbracelet/lipgloss to v0.11.0
by [@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#712
- chore: add schema validation docs by
[@&#8203;UncleGedd](https://github.com/UncleGedd) in
[defenseunicorns/uds-cli#748
- feat: show overrides for deployers by
[@&#8203;TristanHoladay](https://github.com/TristanHoladay) in
[defenseunicorns/uds-cli#674
- chore: adds an ADR for bundle OCI media types by
[@&#8203;UncleGedd](https://github.com/UncleGedd) in
[defenseunicorns/uds-cli#750
- fix: make dev deploy help msg better by
[@&#8203;UncleGedd](https://github.com/UncleGedd) in
[defenseunicorns/uds-cli#756
- chore: caching refactor by
[@&#8203;decleaver](https://github.com/decleaver) in
[defenseunicorns/uds-cli#751
- feat: make runner output prettier in CI by
[@&#8203;UncleGedd](https://github.com/UncleGedd) in
[defenseunicorns/uds-cli#758
- chore: refactor overrides by
[@&#8203;TristanHoladay](https://github.com/TristanHoladay) in
[defenseunicorns/uds-cli#753
- chore(deps): update actions/download-artifact action to v4.1.8 by
[@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#764
- feat: name and version flags on create + generates CLI docs by
[@&#8203;UncleGedd](https://github.com/UncleGedd) in
[defenseunicorns/uds-cli#768
- chore(deps): update actions/setup-node action to v4.0.3 by
[@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#769
- chore(deps): update anchore/sbom-action action to v0.16.1 by
[@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#771
- chore(deps): update docker/setup-buildx-action action to v3.4.0 by
[@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#762
- fix(deps): update module golang.org/x/mod to v0.19.0 by
[@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#763
- chore(deps): update actions/upload-artifact action to v4.3.4 by
[@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#765
- chore: ensure stdout for inspect \[FLAGS] by
[@&#8203;TristanHoladay](https://github.com/TristanHoladay) in
[defenseunicorns/uds-cli#759
- fix(deps): update module github.com/charmbracelet/lipgloss to v0.11.1
by [@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#774
- chore(deps): update actions/setup-go action to v5.0.2 by
[@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#773
- chore(deps): update actions/dependency-review-action action to v4.3.4
by [@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#779
- chore(deps): update github/codeql-action action to v3.25.12 by
[@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#781
- chore: more overrides refactors by
[@&#8203;TristanHoladay](https://github.com/TristanHoladay) in
[defenseunicorns/uds-cli#761
- feat: upgrade Maru to 0.2.2 by
[@&#8203;UncleGedd](https://github.com/UncleGedd) in
[defenseunicorns/uds-cli#783
- chore(deps): update zarf to v0.36.0 by
[@&#8203;renovate](https://github.com/renovate) in
[defenseunicorns/uds-cli#777
- fix: task schema generation using maru and removing runner tests by
[@&#8203;decleaver](https://github.com/decleaver) in
[defenseunicorns/uds-cli#778

**Full Changelog**:
defenseunicorns/uds-cli@v0.12.0...v0.13.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job
log](https://developer.mend.io/github/defenseunicorns/uds-core).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Micah Nagel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ensure all inspect output goes to stdout
3 participants