Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotate more compiler internal types #39053

Merged
merged 5 commits into from
Oct 9, 2019
Merged

Annotate more compiler internal types #39053

merged 5 commits into from
Oct 9, 2019

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Oct 4, 2019 •
edited
Loading

These are internal types. There may be some cases where an annotation was missed, but I used a working strategy of "when it doubt, prefer a non-nullable type if it builds successfully". This is a stepping stone for a follow-up pull request where I start to annotate ISymbol and derived types.

@sharwell sharwell requested a review from a team as a code owner October 4, 2019 00:58
@sharwell sharwell mentioned this pull request Oct 4, 2019
Draft
chsienki
chsienki approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@chsienki chsienki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some general comments, but mostly looks good.

I would like to see a link to an issue in the source for the #nullable disable sections, though.

src/Compilers/Core/Portable/Binding/AbstractLookupSymbolsInfo.cs Outdated Show resolved Hide resolved
src/Compilers/Core/Portable/CodeGen/LocalDefinition.cs Show resolved Hide resolved
src/Compilers/Core/Portable/CodeGen/PrivateImplementationDetails.cs Outdated Show resolved Hide resolved
src/Compilers/Core/Portable/CodeGen/ReferenceDependencyWalker.cs Show resolved Hide resolved
src/Compilers/Core/Portable/PEWriter/ManagedResource.cs Outdated Show resolved Hide resolved
src/ExpressionEvaluator/CSharp/Source/ExpressionCompiler/Symbols/PlaceholderMethodSymbol.cs Show resolved Hide resolved
@sharwell sharwell mentioned this pull request Oct 9, 2019
Closed
333fred
333fred approved these changes Oct 9, 2019
View reviewed changes
Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 5)

@sharwell sharwell merged commit dddac7b into dotnet:master Oct 9, 2019
@sharwell sharwell deleted the compiler-annotations-2 branch October 9, 2019 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekseyTs AlekseyTs AlekseyTs left review comments

@333fred 333fred 333fred approved these changes

@chsienki chsienki chsienki approved these changes

Assignees
No one assigned
Labels
Area-Compilers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sharwell @333fred @AlekseyTs @chsienki