Bigz/fix calculate net user pnl #589
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* start test * improve lp_delta_quote * improve per_lp_delta_quote * init per_lp_base * add rebase functions (wip) * rm err msg * add controller rebase to proper locations * add rebase cargo test * (wip) k out of wack * fix rebase test and add more asserts * format fix * incorp basic example to typescript tests * fix rebase math in position.rs (wip) * wip continue * working baseAssetAmountWithUnsettledLp * mvp encapsulation of update_lp_market_position * src/user.ts: add perLpBase to empty position * remove logs * simplify base unit logic more * add get_per_lp_base_unit * simplify per_lp_fee and add numbers to test * properly set per_lp_base for lp_share=0 in mint_lp_shares (and add sdk/test) * incorp feedback / format * tests/liquidityProvider.ts: work with sdk change * admin.rs: add constraint on per_lp_base range * add apply_lp_rebase_to_perp_position to simulate_settled_lp_position * use get_per_lp_base_unit consistently (wip sdk test for negative lp base) * cut excess return values in calculate_lp_delta * fix getPerpPositionWithLPSettle with negative perLpBase delta --------- Co-authored-by: Chris Heaney <[email protected]>
* sdk: add debug for bulk account loader handleAccountCallbacks * log callbacks individually
|
addressed in #912 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.