bigz/add-unsettled-to-net-user-pnl #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #912 +/- ##
==========================================
+ Coverage 75.08% 75.15% +0.06%
==========================================
Files 131 131
Lines 32694 32806 +112
==========================================
+ Hits 24547 24654 +107
- Misses 8147 8152 +5
|
crispheaney
reviewed
Mar 21, 2024
This was referenced Mar 22, 2024
0xbigz
commented
Apr 20, 2024
| // new aggregate unsettled user stats | ||
| pub quote_asset_amount_with_unsettled_lp: Option<i64>, | ||
| pub net_unsettled_funding_pnl: Option<i64>, | ||
| pub update_amm_summary_stats: bool, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also improves logic for blocking on pnl pool settlement