Move more RMF code from iOS to BSK #2967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
dus7
approved these changes
Jun 20, 2024
| } | ||
| } | ||
|
|
||
| override init(mapping: @escaping EventMapping<RemoteMessagingStoreError>.Mapping) { |
There was a problem hiding this comment.
It's beneficial to add @available(*, unavailable, message: "Use init() instead") so you get an immediate feedback when trying to use this function.
There was a problem hiding this comment.
Absolutely, great idea! Let me update it, thanks!
ayoy
commented
Jun 20, 2024
| @@ -28,11 +28,15 @@ import RemoteMessaging | |||
| import NetworkProtection | |||
| import Subscription | |||
|
|
|||
| struct RemoteMessaging { | |||
| struct RemoteMessagingClient { | |||
There was a problem hiding this comment.
The RemoteMessaging struct had to be renamed to avoid name clashing with RemoteMessaging BSK module. This wasn't the case until we added RemoteMessaging.bundle in the BSK module, which confused the compiler.
| import Foundation | ||
| import RemoteMessaging | ||
|
|
||
| public class RemoteMessagingStoreErrorHandling: EventMapping<RemoteMessagingStoreError> { |
There was a problem hiding this comment.
This class intercepts error events emitted by RemoteMessagingStore and fires pixels as needed.
| } | ||
| } | ||
|
|
||
| override init(mapping: @escaping EventMapping<RemoteMessagingStoreError>.Mapping) { |
There was a problem hiding this comment.
Absolutely, great idea! Let me update it, thanks!
samsymons
added a commit
that referenced
this pull request
Jun 20, 2024
# By Diego Rey Mendez (1) and others # Via GitHub * main: Improve prerequisite checks for VPN start (#2970) Move more RMF code from iOS to BSK (#2967) Remove unneeded pixel after investigation (#2972) Add quality signal for bookmarks database (#2964) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1201621708115095/1207573461751430/f
CC: @amddg44
Description:
This change moves reusable parts of the Remote Messaging Framework code over from the iOS repository.
The moved parts are: storage class, request class, Core Data model and storage unit tests.
Steps to test this PR:
These steps are supposed to ensure that database doesn't get corrupted as a result of moving RMF code to BSK:
RemoteMessagingRequest.swift, updateendpointto returnhttps://www.jsonblob.com/api/1252947611702124544dominik/rmf-bsk.RemoteMessagingClient.swiftto the same value as in step 2.Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template