Improve prerequisite checks for VPN start #2970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 19, 2024
quanganhdo
approved these changes
Jun 20, 2024
diegoreymendez
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Jun 20, 2024
Task/Issue URL: https://app.asana.com/0/1206580121312550/1207613628544128/f iOS PR: duckduckgo/iOS#2970 macOS PR: duckduckgo/macos-browser#2882 What kind of version bump will this require?: Patch ## Description **Goals:** - Validate tunnel start prerequisites and, when they aren't met: - Prevent pixel noise; and - Prevent network calls to our backend. - Also clean up the code a bit so that we no longer use completion callbacks for the tunnel start logic. - Add underlying error information to our wake failure pixels.
diegoreymendez
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Jun 20, 2024
Task/Issue URL: https://app.asana.com/0/1206580121312550/1207613628544128/f BSK: duckduckgo/BrowserServicesKit#854 iOS: duckduckgo/iOS#2970 ## Description **Goals:** - Validate tunnel start prerequisites and, when they aren't met: - Prevent pixel noise; and - Prevent network calls to our backend. - Also clean up the code a bit so that we no longer use completion callbacks for the tunnel start logic.
diegoreymendez
deleted the
diego/prevent-vpn-pixel-noise-without-auth-token
branch
samsymons
added a commit
that referenced
this pull request
Jun 20, 2024
# By Diego Rey Mendez (1) and others # Via GitHub * main: Improve prerequisite checks for VPN start (#2970) Move more RMF code from iOS to BSK (#2967) Remove unneeded pixel after investigation (#2972) Add quality signal for bookmarks database (#2964) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1206580121312550/1207613628544128/f
BSK: duckduckgo/BrowserServicesKit#854
macOS: duckduckgo/macos-browser#2882
Description
Goals:
Testing
Internal references:
Software Engineering Expectations
Technical Design Template