Fix VPN configuration removal to stop the tunnel #3099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
github-actions
bot
added
the
bot: not in app board
1 task
github-actions
bot
removed
the
bot: not in app board
samsymons
reviewed
Jul 18, 2024
samsymons
approved these changes
Jul 19, 2024
diegoreymendez
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Jul 19, 2024
…onitors (#900) Task/Issue URL: https://app.asana.com/0/1207603085593419/1207832283330964/f iOS PR: duckduckgo/iOS#3099 macOS PR: duckduckgo/macos-browser#2991 What kind of version bump will this require?: Patch **Optional**: Tech Design URL: CC: ## Description: Fix the VPN configuration removal handling in the extension to stop the tunnel.
diegoreymendez
commented
Jul 19, 2024
| @@ -64,6 +64,9 @@ | |||
| <Test | |||
| Identifier = "AutoconsentMessageProtocolTests/testEval()"> | |||
| </Test> | |||
| <Test | |||
| Identifier = "SyncSettingsViewControllerErrorTests/test_WhenAccountRemoved_ErrorHandlerSyncDidTurnOffCalled()"> | |||
| </Test> | |||
There was a problem hiding this comment.
Disabling flaky test.
diegoreymendez
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Jul 19, 2024
Task/Issue URL: https://app.asana.com/0/1207603085593419/1207832283330964/f iOS PR: duckduckgo/iOS#3099 BSK PR: duckduckgo/BrowserServicesKit#900 ## Description: Fix the VPN configuration removal handling in the extension to stop the tunnel.
samsymons
added a commit
that referenced
this pull request
Jul 19, 2024
# By Christopher Brind (1) and others # Via GitHub * main: [DuckPlayer] 6 - Init updates and Watch on YouTube (#3066) New Tab Page Shortcuts section (#3104) Fix VPN configuration removal to stop the tunnel (#3099) avoid resizing webview when keyboard shows/hides (#3094) Add support for skipping sending usage pixels for remote messages (#3106) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Jul 19, 2024
# By Daniel Bernal (2) and others # Via GitHub * main: Update BSK for Mac RMF changes (#3107) [DuckPlayer] 7- Open Settings (#3110) [DuckPlayer] 6 - Init updates and Watch on YouTube (#3066) New Tab Page Shortcuts section (#3104) Fix VPN configuration removal to stop the tunnel (#3099) avoid resizing webview when keyboard shows/hides (#3094) Add support for skipping sending usage pixels for remote messages (#3106) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Jul 19, 2024
# By Christopher Brind (9) and others # Via Chris Brind (1) and GitHub (1) * main: (48 commits) Reduce VPN manager instances (#3097) Update BSK for Mac RMF changes (#3107) [DuckPlayer] 7- Open Settings (#3110) [DuckPlayer] 6 - Init updates and Watch on YouTube (#3066) New Tab Page Shortcuts section (#3104) Fix VPN configuration removal to stop the tunnel (#3099) avoid resizing webview when keyboard shows/hides (#3094) Add support for skipping sending usage pixels for remote messages (#3106) Bump submodules/privacy-reference-tests from `a242bf0` to `afb4f61` (#3096) Updates BSK to 171.2.3 Remove print (#3101) Update Package.resolved file (#3102) New Tab Page favorites section (#3083) Properly compare actual value of the entitlement check (#3100) fix ui tests broken by new onboarding and use shared setup flow (#3081) AdHoc lane: Make proper assignment to variable (#3095) Expand AdHoc build workflow, add debug bookmarks screen (#3086) Update BSK to latest - for macOS fix to AdAttribution (#3084) Revert "Fix tests" Fix tests ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/NetworkProtectionStatusViewModel.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207603085593419/1207832283330964/f
macOS PR: duckduckgo/macos-browser#2991
BSK PR: duckduckgo/BrowserServicesKit#900
Description:
Fix the VPN configuration removal handling in the extension to stop the tunnel.
Testing:
There's an option in the debug menu to remove the VPN configuration.
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation