Update BSK for Mac RMF changes #3107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
samsymons
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Jul 19, 2024
Task/Issue URL: https://app.asana.com/0/1199333091098016/1207851439577905/f iOS PR: duckduckgo/iOS#3107 macOS PR: duckduckgo/macos-browser#2995 What kind of version bump will this require?: Major Optional: Tech Design URL: CC: Description: This PR adds a new attribute which can check whether a user interacted with a given remote message via the deprecated messaging system on macOS. This new attribute is a clone of the interactedWithMessage attribute, except we provide a different array. I considered simply appending the deprecated message IDs to the array we pass to interactedWithMessage, but would prefer to keep the arrays distinct in case of reused IDs between the two.
# By Christopher Brind (1) and others # Via GitHub * main: [DuckPlayer] 6 - Init updates and Watch on YouTube (#3066) New Tab Page Shortcuts section (#3104) Fix VPN configuration removal to stop the tunnel (#3099) avoid resizing webview when keyboard shows/hides (#3094) Add support for skipping sending usage pixels for remote messages (#3106) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Jul 19, 2024
# By Daniel Bernal (2) and others # Via GitHub * main: Update BSK for Mac RMF changes (#3107) [DuckPlayer] 7- Open Settings (#3110) [DuckPlayer] 6 - Init updates and Watch on YouTube (#3066) New Tab Page Shortcuts section (#3104) Fix VPN configuration removal to stop the tunnel (#3099) avoid resizing webview when keyboard shows/hides (#3094) Add support for skipping sending usage pixels for remote messages (#3106) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Jul 19, 2024
# By Christopher Brind (9) and others # Via Chris Brind (1) and GitHub (1) * main: (48 commits) Reduce VPN manager instances (#3097) Update BSK for Mac RMF changes (#3107) [DuckPlayer] 7- Open Settings (#3110) [DuckPlayer] 6 - Init updates and Watch on YouTube (#3066) New Tab Page Shortcuts section (#3104) Fix VPN configuration removal to stop the tunnel (#3099) avoid resizing webview when keyboard shows/hides (#3094) Add support for skipping sending usage pixels for remote messages (#3106) Bump submodules/privacy-reference-tests from `a242bf0` to `afb4f61` (#3096) Updates BSK to 171.2.3 Remove print (#3101) Update Package.resolved file (#3102) New Tab Page favorites section (#3083) Properly compare actual value of the entitlement check (#3100) fix ui tests broken by new onboarding and use shared setup flow (#3081) AdHoc lane: Make proper assignment to variable (#3095) Expand AdHoc build workflow, add debug bookmarks screen (#3086) Update BSK to latest - for macOS fix to AdAttribution (#3084) Revert "Fix tests" Fix tests ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/NetworkProtectionStatusViewModel.swift
samsymons
added a commit
that referenced
this pull request
Jul 24, 2024
# By Daniel Bernal (6) and others # Via Chris Brind (3) and others * main: (24 commits) [DuckPlayer] 10 . Move DuckPlayer init to TabManager (#3124) Fix threading issue with Mesage broker (#3132) [Duckplayer] - 9. Edge Cases (#3115) Release 7.130.0-2 (#3134) Internal update for: fix index out-of-bounds in startAttachingCrashLogMessages (#3123) (#3128) Attach params to PPro pixels (#3092) Don't show key icon for empty passwords (#3070) Release 7.129.1-0 (#3127) fix index out-of-bounds in startAttachingCrashLogMessages (#3123) Release 7.130.0-1 (#3122) Revert old Dax icon for old onboarding (#3085) Scroll to Internal User setting (#3114) Release 7.130.0-0 (#3118) Allow activating subscription for internal users via debug menu (#3117) Update breakage report locale to JSON format (#3112) [Duckplayer] 8. Age restricted videos (#3111) Reduce VPN manager instances (#3097) Update BSK for Mac RMF changes (#3107) [DuckPlayer] 7- Open Settings (#3110) [DuckPlayer] 6 - Init updates and Watch on YouTube (#3066) ... # Conflicts: # DuckDuckGo/DuckPlayer/DuckPlayerNavigationHandler.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1199333091098016/1207851439577905/f
Tech Design URL:
CC:
Description:
This PR updates BSK for Mac RMF changes. iOS is not affected.
Steps to test this PR:
Definition of Done (Internal Only):
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template