Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Duckplayer] 8. Age restricted videos #3111

Merged
merged 57 commits into from
Jul 20, 2024

Conversation

afterxleep
Copy link
Collaborator

@afterxleep afterxleep commented Jul 19, 2024

Task/Issue URL: https://app.asana.com/0/0/1207791658630142/f

⚠️ Stacked PR on top of #3110

Description:
Implements restricted video link handling

⚠️ This PR requires a specific branch of CSS to work. Drag a local version of content-scope-scripts package to the app, and point to branch: pr-releases/pr-993

Steps to test this PR:

  • Set DuckPlayer to 'Always'
  • Go to Youtube.com and search for "Rammstein Radio official"
  • Tap the Video result "Rammstein - Radio (Official Video)
  • Confirm DuckPlayer opens and video says "This video is age-restricted"
  • Click "Watch in Youtube" link from the video embed
  • Confirm video opens in Youtube in a new tab
Internal references:

Software Engineering Expectations
Technical Design Template

@afterxleep afterxleep requested a review from Bunn July 19, 2024 13:04
…age.restricted.videos

# Conflicts:
#	DuckDuckGo/DuckPlayer/DuckPlayerNavigationHandler.swift
# Conflicts:
#	DuckDuckGo/DuckPlayer/DuckPlayerNavigationHandler.swift
#	DuckDuckGo/TabViewController.swift
#	submodules/privacy-reference-tests
…r/7.settings

# Conflicts:
#	DuckDuckGo/TabViewController.swift
…age.restricted.videos

# Conflicts:
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
…r/7.settings

# Conflicts:
#	DuckDuckGo/TabViewController.swift
# Conflicts:
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
#	DuckDuckGo/DuckPlayer/DuckPlayer.swift
#	DuckDuckGo/DuckPlayer/DuckPlayerNavigationHandler.swift
#	DuckDuckGo/DuckPlayer/YoutubePlayerUserScript.swift
@afterxleep afterxleep merged commit b908108 into main Jul 20, 2024
14 checks passed
@afterxleep afterxleep deleted the daniel/duckplayer/8.age.restricted.videos branch July 20, 2024 12:01
samsymons added a commit that referenced this pull request Jul 24, 2024
# By Daniel Bernal (6) and others
# Via Chris Brind (3) and others
* main: (24 commits)
  [DuckPlayer] 10 . Move DuckPlayer init to TabManager (#3124)
  Fix threading issue with Mesage broker (#3132)
  [Duckplayer] - 9. Edge Cases (#3115)
  Release 7.130.0-2 (#3134)
  Internal update for: fix index out-of-bounds in startAttachingCrashLogMessages (#3123) (#3128)
  Attach params to PPro pixels (#3092)
  Don't show key icon for empty passwords (#3070)
  Release 7.129.1-0 (#3127)
  fix index out-of-bounds in startAttachingCrashLogMessages (#3123)
  Release 7.130.0-1 (#3122)
  Revert old Dax icon for old onboarding (#3085)
  Scroll to Internal User setting (#3114)
  Release 7.130.0-0 (#3118)
  Allow activating subscription for internal users via debug menu (#3117)
  Update breakage report locale to JSON format (#3112)
  [Duckplayer] 8. Age restricted videos (#3111)
  Reduce VPN manager instances (#3097)
  Update BSK for Mac RMF changes (#3107)
  [DuckPlayer] 7- Open Settings (#3110)
  [DuckPlayer] 6 - Init updates and Watch on YouTube (#3066)
  ...

# Conflicts:
#	DuckDuckGo/DuckPlayer/DuckPlayerNavigationHandler.swift
samsymons added a commit that referenced this pull request Jul 25, 2024
# By Daniel Bernal (4) and others
# Via Chris Brind (3) and others
* main:
  [DuckPlayer] 10 . Move DuckPlayer init to TabManager (#3124)
  Fix threading issue with Mesage broker (#3132)
  [Duckplayer] - 9. Edge Cases (#3115)
  Release 7.130.0-2 (#3134)
  Internal update for: fix index out-of-bounds in startAttachingCrashLogMessages (#3123) (#3128)
  Attach params to PPro pixels (#3092)
  Don't show key icon for empty passwords (#3070)
  Release 7.129.1-0 (#3127)
  fix index out-of-bounds in startAttachingCrashLogMessages (#3123)
  Release 7.130.0-1 (#3122)
  Revert old Dax icon for old onboarding (#3085)
  Scroll to Internal User setting (#3114)
  Release 7.130.0-0 (#3118)
  Allow activating subscription for internal users via debug menu (#3117)
  Update breakage report locale to JSON format (#3112)
  [Duckplayer] 8. Age restricted videos (#3111)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants