Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attach params to PPro pixels #3092

Merged
merged 53 commits into from
Jul 24, 2024
Merged

Attach params to PPro pixels #3092

merged 53 commits into from
Jul 24, 2024

Conversation

quanganhdo
Copy link
Member

@quanganhdo quanganhdo commented Jul 17, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/414235014887631/1207759380490241/f
Tech Design URL:
CC:

Description:

Attach a randomized subset of parameters to certain PPro pixels.

Steps to test:

  1. Use https://www.jsonblob.com/api/1263251505917321216 for remote config
  2. Use https://www.jsonblob.com/api/1263231573443862528 for remote message
  3. Check if the attached params are fired, and if their values are calculated correctly
  4. I also have a Debug menu to show the param values

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie ’ rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme
Internal references:

Software Engineering Expectations
Technical Design Template

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 17, 2024 •
edited
Loading

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against 37cfab6

@quanganhdo
Merge branch 'main' into anh/ppro/pixel-params
31734a8 
# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
#	DuckDuckGo/HomeMessageViewSectionRenderer.swift
#	DuckDuckGo/HomePageConfiguration.swift
#	DuckDuckGo/NewTabPageMessagesModel.swift
@quanganhdo
Update fireproofed site check
7f05bee
@quanganhdo
Refactor
7ecd7f7
@quanganhdo
Fix Swiftlint
f4fffb3
@quanganhdo
Merge branch 'main' into anh/ppro/pixel-params
9409f36 
# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
amddg44
amddg44 approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@amddg44 amddg44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, very nice work! 👏

@quanganhdo
Merge branch 'main' into anh/ppro/pixel-params
d80baa4
@quanganhdo
Merge branch 'main' into anh/ppro/pixel-params
d30fefb 
# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@quanganhdo
Update tests
62acff1
@quanganhdo
Update BSK
fdbbbcd
@quanganhdo
Merge branch 'main' into anh/ppro/pixel-params
0cf2722 
# Conflicts:
#	DuckDuckGo/SubscriptionDebugViewController.swift
@quanganhdo
Fix Swiftlint
360ec8c
@quanganhdo
Update BSK
f56d6d1
@quanganhdo
Update threshold
d092d9f
samsymons
samsymons approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New changes look good, thanks a lot!

@quanganhdo quanganhdo merged commit fb27cdf into main Jul 24, 2024
14 checks passed
@quanganhdo quanganhdo deleted the anh/ppro/pixel-params branch July 24, 2024 03:07
samsymons added a commit that referenced this pull request Jul 24, 2024
@samsymons
Merge branch 'main' into sam/ios-14-cleanup
e497ecb 
# By Daniel Bernal (6) and others
# Via Chris Brind (3) and others
* main: (24 commits)
  [DuckPlayer] 10 . Move DuckPlayer init to TabManager (#3124)
  Fix threading issue with Mesage broker (#3132)
  [Duckplayer] - 9. Edge Cases (#3115)
  Release 7.130.0-2 (#3134)
  Internal update for: fix index out-of-bounds in startAttachingCrashLogMessages (#3123) (#3128)
  Attach params to PPro pixels (#3092)
  Don't show key icon for empty passwords (#3070)
  Release 7.129.1-0 (#3127)
  fix index out-of-bounds in startAttachingCrashLogMessages (#3123)
  Release 7.130.0-1 (#3122)
  Revert old Dax icon for old onboarding (#3085)
  Scroll to Internal User setting (#3114)
  Release 7.130.0-0 (#3118)
  Allow activating subscription for internal users via debug menu (#3117)
  Update breakage report locale to JSON format (#3112)
  [Duckplayer] 8. Age restricted videos (#3111)
  Reduce VPN manager instances (#3097)
  Update BSK for Mac RMF changes (#3107)
  [DuckPlayer] 7- Open Settings (#3110)
  [DuckPlayer] 6 - Init updates and Watch on YouTube (#3066)
  ...

# Conflicts:
#	DuckDuckGo/DuckPlayer/DuckPlayerNavigationHandler.swift
samsymons added a commit that referenced this pull request Jul 25, 2024
@samsymons
Merge branch 'main' into sam/vpn-snooze-initial-support
19b9362 
# By Daniel Bernal (4) and others
# Via Chris Brind (3) and others
* main:
  [DuckPlayer] 10 . Move DuckPlayer init to TabManager (#3124)
  Fix threading issue with Mesage broker (#3132)
  [Duckplayer] - 9. Edge Cases (#3115)
  Release 7.130.0-2 (#3134)
  Internal update for: fix index out-of-bounds in startAttachingCrashLogMessages (#3123) (#3128)
  Attach params to PPro pixels (#3092)
  Don't show key icon for empty passwords (#3070)
  Release 7.129.1-0 (#3127)
  fix index out-of-bounds in startAttachingCrashLogMessages (#3123)
  Release 7.130.0-1 (#3122)
  Revert old Dax icon for old onboarding (#3085)
  Scroll to Internal User setting (#3114)
  Release 7.130.0-0 (#3118)
  Allow activating subscription for internal users via debug menu (#3117)
  Update breakage report locale to JSON format (#3112)
  [Duckplayer] 8. Age restricted videos (#3111)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsymons samsymons samsymons approved these changes

@amddg44 amddg44 amddg44 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@quanganhdo @samsymons @amddg44