client: fix vimeo player not respecting seeks (#1775)

dyc3 · May 11, 2024 · 347b262 · 347b262
1 parent 89262cb
commit 347b262
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/client/src/components/composables/media-player.ts b/client/src/components/composables/media-player.ts
@@ -102,7 +102,8 @@ export class MediaPlayerV2 {
 		}
 		return this.player.value.pause();
 	}
-	getPosition(): number {
+	getPosition(): number | Promise<number> {
+		// vimeo video player returns a promise, so we need to handle that
 		if (!this.checkForPlayer(this.player.value)) {
 			return 0;
 		}

diff --git a/client/src/views/Room.vue b/client/src/views/Room.vue
@@ -344,7 +344,12 @@ export default defineComponent({
 			}
 			const currentTime = player.getPosition();
 
-			if (Math.abs(newPosition - currentTime) > 1 && !mediaPlaybackBlocked.value) {
+			const diff = Math.abs(newPosition - (await currentTime));
+			if (isNaN(diff)) {
+				console.error("player diff is NaN, this is a bug", newPosition, currentTime);
+				return;
+			}
+			if (diff > 1 && !mediaPlaybackBlocked.value) {
 				player.setPosition(newPosition);
 			}
 		});