Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: fix vimeo player not respecting seeks #1775

Merged
merged 1 commit into from
May 11, 2024

Conversation

dyc3
Copy link
Owner

@dyc3 dyc3 commented May 11, 2024

fixes #1774

Copy link
Owner Author

dyc3 commented May 11, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dyc3 and the rest of your teammates on Graphite Graphite

@dyc3 dyc3 marked this pull request as ready for review May 11, 2024 00:50
Copy link

Bundle size diff

diff -u /tmp/bundle-size-base.txt/bundle-size.txt /tmp/bundle-size-head.txt/bundle-size.txt
--- /tmp/bundle-size-base.txt/bundle-size.txt	2024-05-11 00:52:07.614264924 +0000
+++ /tmp/bundle-size-head.txt/bundle-size.txt	2024-05-11 00:52:08.030264454 +0000
@@ -36,13 +36,13 @@
 �[2mdist/�[22m�[2massets/�[22m�[36mHome-hash.js                               �[39m�[1m�[2m    5.43 kB�[22m�[1m�[22m�[2m │ gzip:   1.34 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mYoutubePlayer-hash.js                      �[39m�[1m�[2m    5.86 kB�[22m�[1m�[22m�[2m │ gzip:   2.22 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mde-hash.js                                 �[39m�[1m�[2m   10.79 kB�[22m�[1m�[22m�[2m │ gzip:   4.49 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mfr-hash.js                                 �[39m�[1m�[2m   11.59 kB�[22m�[1m�[22m�[2m │ gzip:   4.78 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mfr-hash.js                                 �[39m�[1m�[2m   11.59 kB�[22m�[1m�[22m�[2m │ gzip:   4.79 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mru-hash.js                                 �[39m�[1m�[2m   12.40 kB�[22m�[1m�[22m�[2m │ gzip:   6.42 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mes-hash.js                                 �[39m�[1m�[2m   14.05 kB�[22m�[1m�[22m�[2m │ gzip:   5.97 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mPeertubePlayer-hash.js                     �[39m�[1m�[2m   16.35 kB�[22m�[1m�[22m�[2m │ gzip:   5.54 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mVimeoPlayer-hash.js                        �[39m�[1m�[2m   39.99 kB�[22m�[1m�[22m�[2m │ gzip:  12.52 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mRoom-hash.js                               �[39m�[1m�[2m  164.05 kB�[22m�[1m�[22m�[2m │ gzip:  51.41 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mGoogleDrivePlayer-hash.js                  �[39m�[1m�[33m  604.87 kB�[39m�[22m�[2m │ gzip: 173.50 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mVimeoPlayer-hash.js                        �[39m�[1m�[2m   39.99 kB�[22m�[1m�[22m�[2m │ gzip:  12.53 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mRoom-hash.js                               �[39m�[1m�[2m  164.14 kB�[22m�[1m�[22m�[2m │ gzip:  51.46 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mGoogleDrivePlayer-hash.js                  �[39m�[1m�[33m  604.87 kB�[39m�[22m�[2m │ gzip: 173.51 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mindex-hash.js                              �[39m�[1m�[33m  743.54 kB�[39m�[22m�[2m │ gzip: 248.18 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mPlyrPlayer-hash.js                         �[39m�[1m�[33m1,280.78 kB�[39m�[22m�[2m │ gzip: 379.36 kB�[22m
-�[32m✓ built in 25.03s�[39m
+�[2mdist/�[22m�[2massets/�[22m�[36mPlyrPlayer-hash.js                         �[39m�[1m�[33m1,280.78 kB�[39m�[22m�[2m │ gzip: 379.37 kB�[22m
+�[32m✓ built in 25.75s�[39m

@dyc3 dyc3 merged commit 347b262 into master May 11, 2024
24 checks passed
@dyc3 dyc3 deleted the 05-10-client_fix_vimeo_player_not_respecting_seeks branch May 11, 2024 00:54
Copy link

cypress bot commented May 11, 2024

Passing run #1977 ↗︎

0 84 1 0 Flakiness 0

Details:

Merge 5b6f5b3 into 89262cb...
Project: OpenTogetherTube Commit: 47c721698b ℹ️
Status: Passed Duration: 05:21 💡
Started: May 11, 2024 12:50 AM Ended: May 11, 2024 12:56 AM

Review all test suite changes for PR #1775 ↗︎

Copy link

cypress bot commented May 11, 2024

Passing run #1978 ↗︎

0 84 1 0 Flakiness 0

Details:

client: fix vimeo player not respecting seeks (#1775)
Project: OpenTogetherTube Commit: 347b262d20
Status: Passed Duration: 05:00 💡
Started: May 11, 2024 12:56 AM Ended: May 11, 2024 1:01 AM

Review all test suite changes for PR #1775 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vimeo Seeking failure
1 participant