Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix new clippy lints #1781

Merged
merged 1 commit into from
Jun 18, 2024
Merged

fix new clippy lints #1781

merged 1 commit into from
Jun 18, 2024

Conversation

dyc3
Copy link
Owner

@dyc3 dyc3 commented Jun 18, 2024

No description provided.

Copy link

Bundle size diff

diff -u /tmp/bundle-size-base.txt/bundle-size.txt /tmp/bundle-size-head.txt/bundle-size.txt
--- /tmp/bundle-size-base.txt/bundle-size.txt	2024-06-18 22:53:54.726107932 +0000
+++ /tmp/bundle-size-head.txt/bundle-size.txt	2024-06-18 22:53:55.130108562 +0000
@@ -30,7 +30,7 @@
 �[2mdist/�[22m�[2massets/�[22m�[36mAttribution-hash.js                        �[39m�[1m�[2m    0.34 kB�[22m�[1m�[22m�[2m │ gzip:   0.26 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mNotFound-hash.js                           �[39m�[1m�[2m    0.60 kB�[22m�[1m�[22m�[2m │ gzip:   0.32 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mplaceholder-hash.js                        �[39m�[1m�[2m    1.04 kB�[22m�[1m�[22m�[2m │ gzip:   0.48 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mPasswordReset-hash.js                      �[39m�[1m�[2m    2.00 kB�[22m�[1m�[22m�[2m │ gzip:   0.95 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mPasswordReset-hash.js                      �[39m�[1m�[2m    2.00 kB�[22m�[1m�[22m�[2m │ gzip:   0.96 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mRoomList-hash.js                           �[39m�[1m�[2m    2.31 kB�[22m�[1m�[22m�[2m │ gzip:   1.08 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mPrivacy-hash.js                            �[39m�[1m�[2m    2.64 kB�[22m�[1m�[22m�[2m │ gzip:   1.29 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mHome-hash.js                               �[39m�[1m�[2m    5.43 kB�[22m�[1m�[22m�[2m │ gzip:   1.34 kB�[22m
@@ -38,11 +38,11 @@
 �[2mdist/�[22m�[2massets/�[22m�[36mde-hash.js                                 �[39m�[1m�[2m   10.79 kB�[22m�[1m�[22m�[2m │ gzip:   4.49 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mfr-hash.js                                 �[39m�[1m�[2m   11.59 kB�[22m�[1m�[22m�[2m │ gzip:   4.79 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mru-hash.js                                 �[39m�[1m�[2m   12.40 kB�[22m�[1m�[22m�[2m │ gzip:   6.42 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mes-hash.js                                 �[39m�[1m�[2m   14.05 kB�[22m�[1m�[22m�[2m │ gzip:   5.97 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mes-hash.js                                 �[39m�[1m�[2m   14.05 kB�[22m�[1m�[22m�[2m │ gzip:   5.98 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mPeertubePlayer-hash.js                     �[39m�[1m�[2m   16.35 kB�[22m�[1m�[22m�[2m │ gzip:   5.54 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mVimeoPlayer-hash.js                        �[39m�[1m�[2m   39.99 kB�[22m�[1m�[22m�[2m │ gzip:  12.53 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mRoom-hash.js                               �[39m�[1m�[2m  164.14 kB�[22m�[1m�[22m�[2m │ gzip:  51.46 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mRoom-hash.js                               �[39m�[1m�[2m  164.14 kB�[22m�[1m�[22m�[2m │ gzip:  51.45 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mGoogleDrivePlayer-hash.js                  �[39m�[1m�[33m  604.87 kB�[39m�[22m�[2m │ gzip: 173.51 kB�[22m
 �[2mdist/�[22m�[2massets/�[22m�[36mindex-hash.js                              �[39m�[1m�[33m  743.54 kB�[39m�[22m�[2m │ gzip: 248.18 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mPlyrPlayer-hash.js                         �[39m�[1m�[33m1,280.78 kB�[39m�[22m�[2m │ gzip: 379.36 kB�[22m
-�[32m✓ built in 24.85s�[39m
+�[2mdist/�[22m�[2massets/�[22m�[36mPlyrPlayer-hash.js                         �[39m�[1m�[33m1,280.78 kB�[39m�[22m�[2m │ gzip: 379.37 kB�[22m
+�[32m✓ built in 25.55s�[39m

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@347b262). Learn more about missing BASE report.

Additional details and impacted files
@@             Coverage Diff             @@
##             master      #1781   +/-   ##
===========================================
  Coverage          ?   62.8300%           
===========================================
  Files             ?        168           
  Lines             ?      24918           
  Branches          ?       1444           
===========================================
  Hits              ?      15656           
  Misses            ?       9209           
  Partials          ?         53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dyc3 dyc3 merged commit b663f1e into master Jun 18, 2024
26 checks passed
@dyc3 dyc3 deleted the fix-new-lints branch June 18, 2024 22:56
Copy link

cypress bot commented Jun 18, 2024

Passing run #1983 ↗︎

0 84 1 0 Flakiness 0

Details:

Merge c5d0b2e into 347b262...
Project: OpenTogetherTube Commit: 2ba3019f59 ℹ️
Status: Passed Duration: 05:16 💡
Started: Jun 18, 2024 10:53 PM Ended: Jun 18, 2024 10:58 PM

Review all test suite changes for PR #1781 ↗︎

Copy link

cypress bot commented Jun 18, 2024

Passing run #1984 ↗︎

0 84 1 0 Flakiness 0

Details:

fix new clippy lints (#1781)
Project: OpenTogetherTube Commit: b663f1eeec
Status: Passed Duration: 04:55 💡
Started: Jun 18, 2024 10:59 PM Ended: Jun 18, 2024 11:04 PM

Review all test suite changes for PR #1781 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant