Remove unneccessary/dead code #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer allow scikit-learn<1.0, so we can remove compatibility. Lots of wet code.
Three of these parameters do nothing. "quiet" is unneccessary - user code should silence.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #347 +/- ##
==========================================
+ Coverage 91.92% 93.95% +2.02%
==========================================
Files 37 37
Lines 3764 3688 -76
==========================================
+ Hits 3460 3465 +5
+ Misses 304 223 -81
☔ View full report in Codecov by Sentry. |
Not tested by default from command line, but explicitly enabled in CI Removed papermill from CI
|
Hey guys I'm giving y'all the heads up about this, but it's pretty minor and if you'd rather not review it, I'll merge it in a few days. |
jpcurbelo
pushed a commit
to jpcurbelo/pysindy_fork
that referenced
this pull request
Apr 30, 2024
Remove unneccessary/dead code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quietparameter inSINDy.fit()isn't our business. Client code should have responsibility for handling warnings. Keepsfit()simpler for subclassing.Technically this is backwards incompatible, but since
masteris tracking a 2.0 release, that should be ok.quietparameter. This motivated refactoring example 1 to the testable format, which also allows us to remove papermill from the CI (pytest tests the notebook, and faster).